From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E150CC33CA9 for ; Mon, 13 Jan 2020 19:17:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A63172080D for ; Mon, 13 Jan 2020 19:17:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="CS1+6M+H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A63172080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2C74D8E0005; Mon, 13 Jan 2020 14:17:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2766C8E0003; Mon, 13 Jan 2020 14:17:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18CA38E0005; Mon, 13 Jan 2020 14:17:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id 03CB28E0003 for ; Mon, 13 Jan 2020 14:17:21 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id AC93082499A8 for ; Mon, 13 Jan 2020 19:17:21 +0000 (UTC) X-FDA: 76373569482.10.train97_602189f7f943 X-HE-Tag: train97_602189f7f943 X-Filterd-Recvd-Size: 2477 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jan 2020 19:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pnrnJUL3meO7e1NBiM9HlyO1v6zxCbpBycwSdqVWSGE=; b=CS1+6M+HVo6LgPrWOqRrh6w2m HmNe2tACzwRn5Ds0L5Xkp1X4TUFFBRGwG+cYC0L+3wb4vPxVrsumKae8SObfGz9+z0Dh7aJHQjL4R WtPxY/O0DRuHPTeFydLaanrTPhvpFgLkO/T0qtLZNP52+82DJeQxw2P57RXM3HCCenioThAxFqMtu Wdp+Kol2qyI1YGxKG6+rmP5Elvj302MqxXyXBJ2vG3L2WPxm2VxmXZAT6zEf1wnXXZLnMLKgXqBaD ISO5hIHnbY4y9619unkDbnW4fWFUXGsklbUHzrxIZLImf2Les/HmOtc+tEAbCQuT+CdLk3KcLuzg8 HPXv0n3bw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ir5DD-0000bp-Tu; Mon, 13 Jan 2020 19:17:19 +0000 Date: Mon, 13 Jan 2020 11:17:19 -0800 From: Matthew Wilcox To: Daniel Wagner Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, jlayton@kernel.org, hch@infradead.org Subject: Re: [PATCH 4/8] mm/fs: Add a_ops->readahead Message-ID: <20200113191719.GD332@bombadil.infradead.org> References: <20200113153746.26654-1-willy@infradead.org> <20200113153746.26654-5-willy@infradead.org> <20200113182242.byzbv5frzyymbddi@beryllium.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200113182242.byzbv5frzyymbddi@beryllium.lan> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 13, 2020 at 07:22:42PM +0100, Daniel Wagner wrote: > > + int (*readahead)(struct file *, struct address_space *, > > + struct pagevec *, pgoff_t index); > > Shouldn't this be no return type? Just trying to map your commit > message to the code. Yes, I'll fix it. I'm not really impressed with the filesystem documentation at this point; I feel like more could be automated and there's too much duplication. > Maybe I just miss the point, in the case, sorry for the noise. Well, mostly I'm looking for architectural and design feedback. I have compiled this code, but not run it.