From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com
Subject: Re: [PATCH 2/2] mm/huge_memory.c: use head to emphasize the purpose of page
Date: Sat, 11 Jan 2020 02:56:37 +0300 [thread overview]
Message-ID: <20200110235637.ppkb6iecd4ayiqr5@box> (raw)
In-Reply-To: <20200110032610.26499-2-richardw.yang@linux.intel.com>
On Fri, Jan 10, 2020 at 11:26:10AM +0800, Wei Yang wrote:
> During split huge page, it checks the property of the page. Currently we
> do the check on page and head without emphasizing the check is on the
> compound page. In case the page passed to split_huge_page_to_list is a
> tail page, audience would take some time to think about whether the
> check is on compound page or tail page itself.
>
> To make it explicit, use head instead of page for those checks. After
> this, audience would be more clear about the checks are on compound page
> and the page is used to do the split and dump error message if failed.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2020-01-10 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 3:26 [PATCH 1/2] mm/huge_memory.c: use head to check huge zero page Wei Yang
2020-01-10 3:26 ` [PATCH 2/2] mm/huge_memory.c: use head to emphasize the purpose of page Wei Yang
2020-01-10 23:56 ` Kirill A. Shutemov [this message]
2020-01-10 23:50 ` [PATCH 1/2] mm/huge_memory.c: use head to check huge zero page Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110235637.ppkb6iecd4ayiqr5@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox