From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E4DFC33CA3 for ; Fri, 10 Jan 2020 16:07:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 144BE206ED for ; Fri, 10 Jan 2020 16:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dahUTwJ3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 144BE206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 80DE18E0006; Fri, 10 Jan 2020 11:07:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BE468E0001; Fri, 10 Jan 2020 11:07:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6856E8E0006; Fri, 10 Jan 2020 11:07:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 530108E0001 for ; Fri, 10 Jan 2020 11:07:41 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id DF191180AD806 for ; Fri, 10 Jan 2020 16:07:40 +0000 (UTC) X-FDA: 76362205080.21.girl51_42fbefe9a901b X-HE-Tag: girl51_42fbefe9a901b X-Filterd-Recvd-Size: 3421 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jan 2020 16:07:39 +0000 (UTC) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE3352087F; Fri, 10 Jan 2020 16:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578672459; bh=NT+C3rfa0dgCpqIe7AgVcCYVZuZOmuBB7mp9Rl6qMH0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dahUTwJ30pZ1S5w3UEki1z3pxuLb35tZGM1zPZZIkphU2wXhzS6Lsbs09//bQTeRj CHwPppKCvWhmzZtu+qLyMu33nUYWb8/QHMewGS+Lq9Pfb0Kwpax18TcdbH8KUgrKEX 6OhasiYhZDvWbZVokhuaha18qHthxUyEWnavFXrQ= Date: Fri, 10 Jan 2020 16:07:34 +0000 From: Will Deacon To: Steven Price Cc: Qian Cai , "akpm@linux-foundation.org" , Catalin Marinas , "linux-arm-kernel@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "sfr@canb.auug.org.au" Subject: Re: [PATCH -next] arm64/mm/dump: fix a compilation error Message-ID: <20200110160734.GA25891@willie-the-truck> References: <20200110145112.7959-1-cai@lca.pw> <20200110153447.GA30104@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110153447.GA30104@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 10, 2020 at 03:34:48PM +0000, Steven Price wrote: > On Fri, Jan 10, 2020 at 02:51:12PM +0000, Qian Cai wrote: > > The linux-next commit "x86: mm: avoid allocating struct mm_struct on the > > stack" [1] introduced a compilation error with "arm64: mm: convert > > mm/dump.c to use walk_page_range()" [2]. Fixed it by using the new API. > > > > arch/arm64/mm/dump.c:326:38: error: too few arguments to function call, > > expected 3, have 2 > > ptdump_walk_pgd(&st.ptdump, info->mm); > > ~~~~~~~~~~~~~~~ ^ > > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here > > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm, > > pgd_t *pgd); > > ^ > > arch/arm64/mm/dump.c:364:38: error: too few arguments to function call, > > expected 3, have 2 > > ptdump_walk_pgd(&st.ptdump, &init_mm); > > ~~~~~~~~~~~~~~~ ^ > > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here > > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm, > > pgd_t *pgd); > > ^ > > 2 errors generated. > > > > [1] http://lkml.kernel.org/r/20200108145710.34314-1-steven.price@arm.com > > Actually this was in the patch I originally posted - somehow it got > lost when Andrew picked it up. > > > [2] http://lkml.kernel.org/r/20191218162402.45610-22-steven.price@arm.com > > > > Signed-off-by: Qian Cai > > Since this matches what I originally wrote... ;) > > Reviewed-by: Steven Price Acked-by: Will Deacon I'm assuming Andrew will queue this alongside the others. Thanks, Will