From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F691C33CA3 for ; Fri, 10 Jan 2020 15:34:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B46032077C for ; Fri, 10 Jan 2020 15:34:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B46032077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BC438E0005; Fri, 10 Jan 2020 10:34:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16E7C8E0001; Fri, 10 Jan 2020 10:34:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 083778E0005; Fri, 10 Jan 2020 10:34:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id E7B6F8E0001 for ; Fri, 10 Jan 2020 10:34:55 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 646F3824805A for ; Fri, 10 Jan 2020 15:34:55 +0000 (UTC) X-FDA: 76362122550.23.wheel76_47fee330e9e47 X-HE-Tag: wheel76_47fee330e9e47 X-Filterd-Recvd-Size: 3681 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jan 2020 15:34:54 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5ACC30E; Fri, 10 Jan 2020 07:34:53 -0800 (PST) Received: from arm.com (e112269-lin.cambridge.arm.com [10.1.194.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB7993F6C4; Fri, 10 Jan 2020 07:34:52 -0800 (PST) Date: Fri, 10 Jan 2020 15:34:48 +0000 From: Steven Price To: Qian Cai Cc: "akpm@linux-foundation.org" , Catalin Marinas , "will@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "sfr@canb.auug.org.au" Subject: Re: [PATCH -next] arm64/mm/dump: fix a compilation error Message-ID: <20200110153447.GA30104@arm.com> References: <20200110145112.7959-1-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110145112.7959-1-cai@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 10, 2020 at 02:51:12PM +0000, Qian Cai wrote: > The linux-next commit "x86: mm: avoid allocating struct mm_struct on the > stack" [1] introduced a compilation error with "arm64: mm: convert > mm/dump.c to use walk_page_range()" [2]. Fixed it by using the new API. > > arch/arm64/mm/dump.c:326:38: error: too few arguments to function call, > expected 3, have 2 > ptdump_walk_pgd(&st.ptdump, info->mm); > ~~~~~~~~~~~~~~~ ^ > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm, > pgd_t *pgd); > ^ > arch/arm64/mm/dump.c:364:38: error: too few arguments to function call, > expected 3, have 2 > ptdump_walk_pgd(&st.ptdump, &init_mm); > ~~~~~~~~~~~~~~~ ^ > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm, > pgd_t *pgd); > ^ > 2 errors generated. > > [1] http://lkml.kernel.org/r/20200108145710.34314-1-steven.price@arm.com Actually this was in the patch I originally posted - somehow it got lost when Andrew picked it up. > [2] http://lkml.kernel.org/r/20191218162402.45610-22-steven.price@arm.com > > Signed-off-by: Qian Cai Since this matches what I originally wrote... ;) Reviewed-by: Steven Price Steve > --- > arch/arm64/mm/dump.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c > index ef4b3ca1e058..860c00ec8bd3 100644 > --- a/arch/arm64/mm/dump.c > +++ b/arch/arm64/mm/dump.c > @@ -323,7 +323,7 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info *info) > } > }; > > - ptdump_walk_pgd(&st.ptdump, info->mm); > + ptdump_walk_pgd(&st.ptdump, info->mm, NULL); > } > > static void ptdump_initialize(void) > @@ -361,7 +361,7 @@ void ptdump_check_wx(void) > } > }; > > - ptdump_walk_pgd(&st.ptdump, &init_mm); > + ptdump_walk_pgd(&st.ptdump, &init_mm, NULL); > > if (st.wx_pages || st.uxn_pages) > pr_warn("Checked W+X mappings: FAILED, %lu W+X pages found, %lu non-UXN pages found\n", > -- > 2.21.0 (Apple Git-122.2) >