From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC11CC282DD for ; Fri, 10 Jan 2020 14:54:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 906B72087F for ; Fri, 10 Jan 2020 14:54:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="H02JMG8k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 906B72087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 18D1D8E0007; Fri, 10 Jan 2020 09:54:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13E3A8E0001; Fri, 10 Jan 2020 09:54:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02C728E0007; Fri, 10 Jan 2020 09:54:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id DCFA18E0001 for ; Fri, 10 Jan 2020 09:54:56 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 934023ABF for ; Fri, 10 Jan 2020 14:54:56 +0000 (UTC) X-FDA: 76362021792.16.table88_df69cc1b2661 X-HE-Tag: table88_df69cc1b2661 X-Filterd-Recvd-Size: 4060 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jan 2020 14:54:55 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id w1so2434125ljh.5 for ; Fri, 10 Jan 2020 06:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SIr8YjUlHXwroCw7JSyezNjS+8rrWXmTvnkdQl1GRZY=; b=H02JMG8k/CsF40jcBWeJH8di2gQR3VJUngbt04jtkSXT33aLg7YIwhtE7GSR1girlo 7jj2BlN3aM2B/M7rnWO8SMEBsfpb5int6DVFpWyaagSh09+dpLLuhfXWg+BHZZaj+fDi GTPL84VPhu4Pc1M8XCpW7L+6hnCGKiQZzzeS2Ry3F+tr2Te5ppFT8jTJcPu+yksk46mT mIXtL5L29NINfDBevNH8uUXC2sE8MzUBTrLCGy/132gDocs/d/EVdKVcELDpGNQvycip z9hKV5W6J1DDffrFHv336ZPyc6Kc9bLqYfIwHTVDjZITPoTqzXAeP0zCAp01fKMXquf0 b+Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SIr8YjUlHXwroCw7JSyezNjS+8rrWXmTvnkdQl1GRZY=; b=FcZB3VjRDHAzlpkYtG6Sx6KkdUxk6qy1qeFT9/GFGPJ2cC10H1wJTnx1kOLP25Ccs1 rxtSs1MRdb6g6mPh9MlUc78QRzaNV5UE66ap08RvRzXVa1zmPFdlXvH0MUoXaoe3uAJU 3gwSMgi3GS9vtcwqtrTgVSM/bqEhQCAx+h6NKe+aQrmo4+UIqAcZxsxlgKuipASfKH6x /Yn7+qknjWDBniggKyJgE0c8bspIrynIngi3neNxAmiNln2vQviWJs8XQmFFBdzw/VRS 9REveWlIcEc119HmmD0EafREr+S0KQOfd2b4CwzUo+PVGfYdqLM3HJr8oRRzpUxJtBqM CQzA== X-Gm-Message-State: APjAAAWIdWugyE1RIp4tm0bgd6oEHz8wqMST833XvIAu/ptRnP/t6e2L y/3nLmidwcSpAyIWljxMJA3UtA== X-Google-Smtp-Source: APXvYqwFUfr/JO3laFVMUUcUEgIU7jfdmhle2+BHKv9pbpNkcc1QHW/uK0hL4xi6f6FfjnhxM9NtpQ== X-Received: by 2002:a2e:914d:: with SMTP id q13mr3034950ljg.198.1578668094480; Fri, 10 Jan 2020 06:54:54 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id b17sm1098592ljd.5.2020.01.10.06.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2020 06:54:53 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 4D4B9100C65; Fri, 10 Jan 2020 17:54:54 +0300 (+03) Date: Fri, 10 Jan 2020 17:54:54 +0300 From: "Kirill A. Shutemov" To: David Hildenbrand Cc: Michal Hocko , Andrew Morton , Dan Williams , Vlastimil Babka , Mel Gorman , "Jin, Zhi" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: Re: [PATCH] mm/page_alloc: Skip non present sections on zone initialization Message-ID: <20200110145454.mmgmtcy2zsrr63vh@box> References: <20191230093828.24613-1-kirill.shutemov@linux.intel.com> <20200108144044.GB30379@dhcp22.suse.cz> <73437651-822f-fcec-3b96-281fb1064cf8@redhat.com> <20200110134547.v6ju5dxazknfjdj3@box> <20200110144717.xufpf4yjkjlngymy@box> <6cf49e65-ee02-7cbd-596f-ebbc057717c2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6cf49e65-ee02-7cbd-596f-ebbc057717c2@redhat.com> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 10, 2020 at 03:48:39PM +0100, David Hildenbrand wrote: > >> + if (!present_section_nr(section_nr)) > >> + return section_nr_to_pfn(next_present_section_nr(section_nr)); > > > > This won't compile. next_present_section_nr() is static to mm/sparse.c. > > We should then move that to the header IMHO. It looks like too much for a trivial cleanup. -- Kirill A. Shutemov