From: Chris Down <chris@chrisdown.name>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-mm@kvack.org, Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@infradead.org>,
Amir Goldstein <amir73il@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH v5 2/2] tmpfs: Support 64-bit inums per-sb
Date: Tue, 7 Jan 2020 00:16:43 +0000 [thread overview]
Message-ID: <20200107001643.GA485121@chrisdown.name> (raw)
In-Reply-To: <20200107001039.GM23195@dread.disaster.area>
Dave Chinner writes:
>It took 15 years for us to be able to essentially deprecate
>inode32 (inode64 is the default behaviour), and we were very happy
>to get that albatross off our necks. In reality, almost everything
>out there in the world handles 64 bit inodes correctly
>including 32 bit machines and 32bit binaries on 64 bit machines.
>And, IMNSHO, there no excuse these days for 32 bit binaries that
>don't using the *64() syscall variants directly and hence support
>64 bit inodes correctlyi out of the box on all platforms.
>
>I don't think we should be repeating past mistakes by trying to
>cater for broken 32 bit applications on 64 bit machines in this day
>and age.
I'm very glad to hear that. I strongly support moving to 64-bit inums in all
cases if there is precedent that it's not a compatibility issue, but from the
comments on my original[0] patch (especially that they strayed from the
original patches' change to use ino_t directly into slab reuse), I'd been given
the impression that it was known to be one.
From my perspective I have no evidence that inode32 is needed other than the
comment from Jeff above get_next_ino. If that turns out not to be a problem, I
am more than happy to just wholesale migrate 64-bit inodes per-sb in tmpfs.
0: https://lore.kernel.org/patchwork/patch/1170963/
next prev parent reply other threads:[~2020-01-07 0:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 12:05 [PATCH v5 0/2] fs: inode: shmem: Reduce risk of inum overflow Chris Down
2020-01-05 12:06 ` [PATCH v5 1/2] tmpfs: Add per-superblock i_ino support Chris Down
2020-01-06 2:03 ` zhengbin (A)
2020-01-06 6:41 ` Amir Goldstein
2020-01-07 8:01 ` Hugh Dickins
2020-01-07 8:35 ` Amir Goldstein
2020-01-08 10:58 ` Hugh Dickins
2020-01-08 12:51 ` Amir Goldstein
2020-01-06 13:17 ` Chris Down
2020-01-05 12:06 ` [PATCH v5 2/2] tmpfs: Support 64-bit inums per-sb Chris Down
2020-01-07 0:10 ` Dave Chinner
2020-01-07 0:16 ` Chris Down [this message]
2020-01-07 0:39 ` Dave Chinner
2020-01-07 6:54 ` Amir Goldstein
2020-01-07 8:36 ` Hugh Dickins
2020-01-07 10:12 ` Amir Goldstein
2020-01-07 21:07 ` Dave Chinner
2020-01-07 21:37 ` Chris Mason
2020-01-08 11:24 ` Hugh Dickins
2020-01-09 0:43 ` Jeff Layton
2020-01-10 16:45 ` Chris Down
2020-01-13 7:36 ` Hugh Dickins
2020-01-20 15:11 ` Chris Down
2020-02-25 23:14 ` Hugh Dickins
2020-01-07 20:59 ` Dave Chinner
2020-01-08 14:37 ` Mikael Magnusson
2020-01-13 6:58 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107001643.GA485121@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jlayton@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox