From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7F9C33C8C for ; Mon, 6 Jan 2020 13:17:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 204522071A for ; Mon, 6 Jan 2020 13:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="w0ppQOyx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 204522071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA1108E0007; Mon, 6 Jan 2020 08:17:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2A668E0001; Mon, 6 Jan 2020 08:17:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F2B98E0007; Mon, 6 Jan 2020 08:17:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id 761278E0001 for ; Mon, 6 Jan 2020 08:17:22 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id EE4C918C9 for ; Mon, 6 Jan 2020 13:17:21 +0000 (UTC) X-FDA: 76347260682.18.coat94_5d5ecc954fd1e X-HE-Tag: coat94_5d5ecc954fd1e X-Filterd-Recvd-Size: 3562 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Jan 2020 13:17:21 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id d16so49547490wre.10 for ; Mon, 06 Jan 2020 05:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FR/KySs86ffBpbHH+kpMl4ePalFaMSRboiPIel9rYrI=; b=w0ppQOyxa9BpzzUmN9s31SbUIxxKvXZjxngFTwTH+s32uOaLCPYjI/iHVnLLcWlMSj yyjUqXbbtGQxjoFWSn+ep7gJJ1grJgq/J5VOaiPeHf+usEwXYKp9d0xdtjoloz777RY+ MUWECSR/Oz2K/azWLZm6hQla6gYy/D4RHlOo0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FR/KySs86ffBpbHH+kpMl4ePalFaMSRboiPIel9rYrI=; b=Z4tbdquMC/67/BiGEnLGA09ZIjiaOTs53eMVswTAoiolm70ZyPNk0HHXaEIPaJtT3/ CBMXwW/up7LTn6EQPGZHcnFgAv8zp4AEMvNjBhHXcD7UCGuw5WK97xoXW9V5Zl5IdL8f mlS/XPx2Ooo6XqaVGCtjDtzdGrj7F0vFzDN/X11NDAU8q2IAJ7uR/MX4RcDGK3vEHrpd eI1pbdnZZ918d/Lca1pULWmW1VwvpJKVcA0YsiPEpdc3lroduYk36KzuUyk7/Uh8QrQy MyxX3jBuH2zXZBFbl94akfmHLoQEjRIXoNAomwuojVElcR62rAXN3a6K/rCCQNCJgamU yl1A== X-Gm-Message-State: APjAAAUzzJ/12DiyU/ioEY53SxerAokUo0TUCDGBkXhPfMJMOTJHbmzn 91fJc4wHl74N2Dj+9DOXE/C3Fg== X-Google-Smtp-Source: APXvYqwydYsFcx/lAJEweADm0F8TYKxbw+Ktk9jZs3fwgCWfVmUr7KAwfkYV5CH+hA+r33UHztVEEw== X-Received: by 2002:a5d:6441:: with SMTP id d1mr103180769wrw.93.1578316640253; Mon, 06 Jan 2020 05:17:20 -0800 (PST) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id o4sm70942309wrx.25.2020.01.06.05.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 05:17:19 -0800 (PST) Date: Mon, 6 Jan 2020 13:17:19 +0000 From: Chris Down To: "zhengbin (A)" Cc: linux-mm@kvack.org, Hugh Dickins , Andrew Morton , Al Viro , Matthew Wilcox , Amir Goldstein , Jeff Layton , Johannes Weiner , Tejun Heo , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v5 1/2] tmpfs: Add per-superblock i_ino support Message-ID: <20200106131719.GB361303@chrisdown.name> References: <91b4ed6727712cb6d426cf60c740fe2f473f7638.1578225806.git.chris@chrisdown.name> <4106bf3f-5c99-77a4-717e-10a0ffa6a3fa@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <4106bf3f-5c99-77a4-717e-10a0ffa6a3fa@huawei.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: zhengbin (A) writes: >Use spin_lock will affect performance "Performance" isn't a binary. In discussions, you should avoid invoking the performance boogeyman without presenting any real-world data. :-) We already have to take this spin lock before when setting the free inode count. The two sites can be merged, but it seems unnecessary to conflate their purpose at this time.