From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6072FC33C8C for ; Mon, 6 Jan 2020 11:57:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A5DD20731 for ; Mon, 6 Jan 2020 11:57:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A5DD20731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BEF1B8E0006; Mon, 6 Jan 2020 06:57:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9F358E0001; Mon, 6 Jan 2020 06:57:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB4BD8E0006; Mon, 6 Jan 2020 06:57:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 951AC8E0001 for ; Mon, 6 Jan 2020 06:57:37 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 36EF2180AD801 for ; Mon, 6 Jan 2020 11:57:37 +0000 (UTC) X-FDA: 76347059754.14.twig91_7ca4c8fcce263 X-HE-Tag: twig91_7ca4c8fcce263 X-Filterd-Recvd-Size: 5335 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Jan 2020 11:57:36 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id p9so14687668wmc.2 for ; Mon, 06 Jan 2020 03:57:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Wq5ckQk7LFGLcvmKNi6yRQD928FRQYB9nCju3+NM16s=; b=r32i2nPXam+5LarsCwmTRDftr0/vPEwXHMCd2SCjkbDXC5NrQTKIpSAAMwyQbT3BEe B3XvkJRLcfdMHEsvRDa/dRrv2aeJFw5Tc6RwOGXw+OV2KSeCMM7ZPhZ9d0J0nPQqBcEZ Siajuuvf23vCacut7GA8JBrOaroNs0tbtvEH7bzvKWNpqynBw1f99w+7Eh+aznyRPo4o MiZncqx3zzJZit+tAFYz8AbXeUCj7BECTjLY6BOAJg89276r6X28xCdMv7owOa0bzv1R 4Aj2tya8Nwadwe1yC5SHh7teJSU0UyqDs6aY4MvOofCw9DHQSyc0Bb+PZ+pPIgj0N9Tl nSdw== X-Gm-Message-State: APjAAAUW6Ye0f6GG07cWadoRKv2jqprs5gu0l3lOrCaWGCakyrTX5e6A DMXy19FnHa1xEXBNKVEyj2s= X-Google-Smtp-Source: APXvYqz+K5ThOJvt/fr4HLv1TX9A/QH8tzGeDdL9+NBitXIU6Wt0jJh/hTjo2ms6UIQKX9U5J7xDGA== X-Received: by 2002:a05:600c:246:: with SMTP id 6mr35470768wmj.122.1578311855456; Mon, 06 Jan 2020 03:57:35 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id f127sm22452306wma.4.2020.01.06.03.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 03:57:34 -0800 (PST) Date: Mon, 6 Jan 2020 12:57:33 +0100 From: Michal Hocko To: Christopher Lameter Cc: LKML , linux-mm@kvack.org, Andrew Morton Subject: Re: SLUB: purpose of sysfs events on cache creation/removal Message-ID: <20200106115733.GH12699@dhcp22.suse.cz> References: <20191126165420.GL20912@dhcp22.suse.cz> <20191127162400.GT20912@dhcp22.suse.cz> <20191127174317.GD26807@dhcp22.suse.cz> <20191204132812.GF25242@dhcp22.suse.cz> <20191204153225.GM25242@dhcp22.suse.cz> <20191204173224.GN25242@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204173224.GN25242@dhcp22.suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 04-12-19 18:32:24, Michal Hocko wrote: > [Cc akpm - the email thread starts > http://lkml.kernel.org/r/20191126121901.GE20912@dhcp22.suse.cz] ping. > On Wed 04-12-19 16:53:47, Cristopher Lameter wrote: > > On Wed, 4 Dec 2019, Michal Hocko wrote: > > > > > As I've said I believe it is quite risky. But if you as a maintainer > > > believe this is the right thing to do I will not object. Care to send a > > > patch? > > > > From: Christoph Lameter > > Subject: slub: Remove userspace notifier for cache add/remove > > > > Kmem caches are internal kernel structures so it is strange that > > userspace notifiers would be needed. And I am not aware of any use > > of these notifiers. These notifiers may just exist because in the > > initial slub release the sysfs code was copied from another > > subsystem. > > > > Signed-off-by: Christoph Lameter > > > > Index: linux/mm/slub.c > > =================================================================== > > --- linux.orig/mm/slub.c 2019-12-02 15:13:23.948312925 +0000 > > +++ linux/mm/slub.c 2019-12-04 16:32:34.648550310 +0000 > > @@ -5632,19 +5632,6 @@ static struct kobj_type slab_ktype = { > > .release = kmem_cache_release, > > }; > > > > -static int uevent_filter(struct kset *kset, struct kobject *kobj) > > -{ > > - struct kobj_type *ktype = get_ktype(kobj); > > - > > - if (ktype == &slab_ktype) > > - return 1; > > - return 0; > > -} > > - > > -static const struct kset_uevent_ops slab_uevent_ops = { > > - .filter = uevent_filter, > > -}; > > - > > static struct kset *slab_kset; > > > > static inline struct kset *cache_kset(struct kmem_cache *s) > > @@ -5712,7 +5699,6 @@ static void sysfs_slab_remove_workfn(str > > #ifdef CONFIG_MEMCG > > kset_unregister(s->memcg_kset); > > #endif > > - kobject_uevent(&s->kobj, KOBJ_REMOVE); > > out: > > kobject_put(&s->kobj); > > } > > @@ -5770,7 +5756,6 @@ static int sysfs_slab_add(struct kmem_ca > > } > > #endif > > > > - kobject_uevent(&s->kobj, KOBJ_ADD); > > if (!unmergeable) { > > /* Setup first alias */ > > sysfs_slab_alias(s, s->name); > > @@ -5851,7 +5836,7 @@ static int __init slab_sysfs_init(void) > > > > mutex_lock(&slab_mutex); > > > > - slab_kset = kset_create_and_add("slab", &slab_uevent_ops, kernel_kobj); > > + slab_kset = kset_create_and_add("slab", NULL, kernel_kobj); > > if (!slab_kset) { > > mutex_unlock(&slab_mutex); > > pr_err("Cannot register slab subsystem.\n"); > > -- > Michal Hocko > SUSE Labs -- Michal Hocko SUSE Labs