From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B2CAC2D0C2 for ; Fri, 3 Jan 2020 20:37:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A3C0921835 for ; Fri, 3 Jan 2020 20:37:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3C0921835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=us.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 07AD98E0005; Fri, 3 Jan 2020 15:37:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02BC08E0003; Fri, 3 Jan 2020 15:37:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5C048E0005; Fri, 3 Jan 2020 15:37:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id CD7EE8E0003 for ; Fri, 3 Jan 2020 15:37:35 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 7D9DD2816 for ; Fri, 3 Jan 2020 20:37:35 +0000 (UTC) X-FDA: 76337483670.04.plane79_7c4a88f50a432 X-HE-Tag: plane79_7c4a88f50a432 X-Filterd-Recvd-Size: 4431 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jan 2020 20:37:33 +0000 (UTC) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 003KbV5c019693 for ; Fri, 3 Jan 2020 15:37:32 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xa48kx7p0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 03 Jan 2020 15:37:32 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Jan 2020 20:37:22 -0000 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 3 Jan 2020 20:37:18 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 003KbH9n39190900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 Jan 2020 20:37:17 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 66AAFA405F; Fri, 3 Jan 2020 20:37:17 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 89413A405C; Fri, 3 Jan 2020 20:37:15 +0000 (GMT) Received: from oc0525413822.ibm.com (unknown [9.80.213.131]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 3 Jan 2020 20:37:15 +0000 (GMT) Date: Fri, 3 Jan 2020 12:37:12 -0800 From: Ram Pai To: Sukadev Bhattiprolu Cc: Michael Ellerman , Paul Mackerras , bharata@linux.ibm.com, linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 2/2] KVM: PPC: Implement H_SVM_INIT_ABORT hcall Reply-To: Ram Pai References: <20191219215146.27278-1-sukadev@linux.ibm.com> <20191219215146.27278-2-sukadev@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191219215146.27278-2-sukadev@linux.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 20010320-0012-0000-0000-0000037A4AAB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20010320-0013-0000-0000-000021B65F2B Message-Id: <20200103203712.GG5556@oc0525413822.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2020-01-03_06:2020-01-02,2020-01-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=838 mlxscore=0 suspectscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001030187 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 19, 2019 at 01:51:46PM -0800, Sukadev Bhattiprolu wrote: > Implement the H_SVM_INIT_ABORT hcall which the Ultravisor can use to > abort an SVM after it has issued the H_SVM_INIT_START and before the > H_SVM_INIT_DONE hcalls. This hcall could be used when Ultravisor > encounters security violations or other errors when starting an SVM. > ..snip.. > +unsigned long kvmppc_h_svm_init_abort(struct kvm *kvm) > +{ > + int srcu_idx; > + struct kvm_memory_slot *memslot; > + > + /* > + * Expect to be called only after INIT_START and before INIT_DONE. > + * If INIT_DONE was completed, use normal VM termination sequence. > + */ > + if (!(kvm->arch.secure_guest & KVMPPC_SECURE_INIT_START) || > + (kvm->arch.secure_guest & KVMPPC_SECURE_INIT_DONE)) > + return H_UNSUPPORTED; Ah.. this version has already incorporated my prior comment! I should have reviewed your v4 version first. One small comment.. H_STATE is a better return code than H_UNSUPPORTED. RP