From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7244EC3276C for ; Fri, 3 Jan 2020 02:20:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 21C2F2085B for ; Fri, 3 Jan 2020 02:20:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21C2F2085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=us.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 70D878E000A; Thu, 2 Jan 2020 21:20:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BE9D8E0003; Thu, 2 Jan 2020 21:20:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D4E78E000A; Thu, 2 Jan 2020 21:20:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 48EAF8E0003 for ; Thu, 2 Jan 2020 21:20:31 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id E5AF740CD for ; Fri, 3 Jan 2020 02:20:30 +0000 (UTC) X-FDA: 76334719020.10.pigs79_456c16b2083e X-HE-Tag: pigs79_456c16b2083e X-Filterd-Recvd-Size: 4540 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jan 2020 02:20:29 +0000 (UTC) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0032HKKI065160 for ; Thu, 2 Jan 2020 21:20:28 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2x88jfhgnm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 02 Jan 2020 21:20:28 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Jan 2020 02:20:26 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 3 Jan 2020 02:20:23 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0032KMuH50462858 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 Jan 2020 02:20:23 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D91F042041; Fri, 3 Jan 2020 02:20:22 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CC0A942049; Fri, 3 Jan 2020 02:20:20 +0000 (GMT) Received: from oc0525413822.ibm.com (unknown [9.80.213.131]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 3 Jan 2020 02:20:20 +0000 (GMT) Date: Thu, 2 Jan 2020 18:20:17 -0800 From: Ram Pai To: Sukadev Bhattiprolu Cc: Michael Ellerman , Paul Mackerras , Bharata B Rao , kvm-ppc@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH V3 2/2] KVM: PPC: Implement H_SVM_INIT_ABORT hcall Reply-To: Ram Pai References: <20191215021104.GA27378@us.ibm.com> <20191215021208.GB27378@us.ibm.com> <20200103001814.GD5556@oc0525413822.ibm.com> <20200103003233.GA16216@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200103003233.GA16216@us.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 20010302-0020-0000-0000-0000039D642D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20010302-0021-0000-0000-000021F4B42D Message-Id: <20200103022017.GF5556@oc0525413822.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2020-01-02_08:2020-01-02,2020-01-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 spamscore=0 priorityscore=1501 suspectscore=0 phishscore=0 mlxlogscore=698 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001030020 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 02, 2020 at 04:32:33PM -0800, Sukadev Bhattiprolu wrote: > Ram Pai [linuxram@us.ibm.com] wrote: > > > +unsigned long kvmppc_h_svm_init_abort(struct kvm *kvm) > > > +{ > > > + int i; > > > + > > > + if (!(kvm->arch.secure_guest & KVMPPC_SECURE_INIT_START)) > > > + return H_UNSUPPORTED; > > > > It should also return H_UNSUPPORTED when > > (kvm->arch.secure_guest & KVMPPC_SECURE_INIT_DONE) is true. > > If KVMPPC_SECURE_INIT_DONE is set, KVMPPC_SECURE_INIT_START is also > set - we never clear KVMPPC_SECURE_INIT_START right? I am concerned about the case, where the VM has successfully transitioned into a SVM, where both KVMPPC_SECURE_INIT_DONE and KVMPPC_SECURE_INIT_START are set. In this scenario, if the UV makes a H_SVM_INIT_ABORT hcall, the Hypervisor will not return H_UNSUPPORTED, because KVMPPC_SECURE_INIT_START is set. That is the reason, I think, we need to add another check as below. if (kvm->arch.secure_guest & KVMPPC_SECURE_INIT_DONE) return H_UNSUPPORTED; > > Sukadev -- Ram Pai