From: Andrew Morton <akpm@linux-foundation.org>
To: vitaly.wool@konsulko.com
Cc: linux-mm@kvack.org, ddstreet@ieee.org
Subject: Re: [PATCH] zswap: add allocation hysteresis if pool limit is hit
Date: Tue, 31 Dec 2019 14:57:02 -0800 [thread overview]
Message-ID: <20191231145702.69b5d7ed73d4b29a3679ebeb@linux-foundation.org> (raw)
In-Reply-To: <20191225203730.4632-1-vitaly.wool@konsulko.com>
On Wed, 25 Dec 2019 22:37:30 +0200 vitaly.wool@konsulko.com wrote:
> From: Vitaly Wool <vitaly.wool@konsulko.com>
>
> zswap will always try to shrink pool when zswap is full. If there
> is a high pressure on zswap it will result in flipping pages in
> and out zswap pool without any real benefit, and the overall system
> performance will drop. The previous discussion on this subject [1]
> ended up with a suggestion to implement a sort of hysteresis to
> refuse taking pages into zswap pool until it has sufficient space
> if the limit has been hit. This is my take on this.
>
> Hysteresis is controlled with a sysfs-configurable parameter
> 'accept_threhsold_percent'. It specifies the threshold at which
> zswap would start accepting pages again after it became full.
Please let's give the full path to the sysfs file.
Can we please include an update to the documentation?
Documentation/vm/zswap.rst, I assume.
prev parent reply other threads:[~2019-12-31 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 20:37 vitaly.wool
2019-12-31 22:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191231145702.69b5d7ed73d4b29a3679ebeb@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-mm@kvack.org \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox