From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EAEFC2D0CE for ; Mon, 30 Dec 2019 15:32:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DDD5320663 for ; Mon, 30 Dec 2019 15:32:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDD5320663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D2EC8E0005; Mon, 30 Dec 2019 10:32:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4839B8E0003; Mon, 30 Dec 2019 10:32:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 372248E0005; Mon, 30 Dec 2019 10:32:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 1FFCF8E0003 for ; Mon, 30 Dec 2019 10:32:43 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id C36BF8249980 for ; Mon, 30 Dec 2019 15:32:42 +0000 (UTC) X-FDA: 76322200164.24.stage80_8bfe84e48c63d X-HE-Tag: stage80_8bfe84e48c63d X-Filterd-Recvd-Size: 2933 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [195.130.132.52]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Dec 2019 15:32:41 +0000 (UTC) Received: from ramsan ([84.195.182.253]) by xavier.telenet-ops.be with bizsmtp id kFYf2100M5USYZQ01FYfzW; Mon, 30 Dec 2019 16:32:40 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1ilx27-0002y1-BD; Mon, 30 Dec 2019 16:32:39 +0100 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1ilx27-0007md-7q; Mon, 30 Dec 2019 16:32:39 +0100 From: Geert Uytterhoeven To: Trond Myklebust , Anna Schumaker , Rik van Riel , Mel Gorman , Andrew Morton Cc: linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH/RFC] nfs: NFS_SWAP should depend on SWAP Date: Mon, 30 Dec 2019 16:32:38 +0100 Message-Id: <20191230153238.29878-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If CONFIG_SWAP=n, it does not make much sense to offer the user the option to enable support for swapping over NFS, as that will still fail at run time: # swapon /swap swapon: /swap: swapon failed: Function not implemented Fix this by adding a dependency on CONFIG_SWAP. Fixes: a564b8f0398636ba ("nfs: enable swap on NFS") Signed-off-by: Geert Uytterhoeven --- Marked RFC, as this still doesn't seem to work. When enabled, the kernel log is spammed with: [ 449.371536] __swap_writepage: 413288 callbacks suppressed [ 449.371577] Write error on dio swapfile (10047488) [ 449.382435] Write error on dio swapfile (14147584) [ 449.387320] Write error on dio swapfile (10919936) [ 449.392474] Write error on dio swapfile (8945664) [ 449.397263] Write error on dio swapfile (24256512) [ 449.402330] Write error on dio swapfile (14307328) [ 449.407195] Write error on dio swapfile (229376) [ 449.412031] Write error on dio swapfile (10293248) [ 449.416891] Write error on dio swapfile (2007040) Platform is 32-bit Cortex A9 with 32 MiB of RAM (hence the need for swap). --- fs/nfs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig index 295a7a21b7744014..e7dd07f47825939e 100644 --- a/fs/nfs/Kconfig +++ b/fs/nfs/Kconfig @@ -90,7 +90,7 @@ config NFS_V4 config NFS_SWAP bool "Provide swap over NFS support" default n - depends on NFS_FS + depends on NFS_FS && SWAP select SUNRPC_SWAP help This option enables swapon to work on files located on NFS mounts. -- 2.17.1