linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Christopher Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"dclarke@blastwave.org" <dclarke@blastwave.org>,
	"bugzilla-daemon@bugzilla.kernel.org"
	<bugzilla-daemon@bugzilla.kernel.org>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>, Qian Cai <cai@lca.pw>,
	"longman@redhat.com" <longman@redhat.com>
Subject: Re: [Bug 205937] New: BUG: unable to handle page fault for address: f3170000
Date: Thu, 26 Dec 2019 23:58:04 +0000	[thread overview]
Message-ID: <20191226235801.GD22734@tower.dhcp.thefacebook.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1912262138010.24955@www.lameter.com>

On Thu, Dec 26, 2019 at 09:41:30PM +0000, Christopher Lameter wrote:
> On Mon, 23 Dec 2019, Andrew Morton wrote:
> 
> > Guys, did we make recent changes in this area?
> 
> Yes the cgroup folks did. f.e.
> 
> commit 04f768a39d55967246c002aa66b407b3bfdd8269
> Author: Waiman Long <longman@redhat.com>
> Date:   Mon Sep 23 15:33:46 2019 -0700
> 
>     mm, slab: extend slab/shrink to shrink all memcg caches

I'd be surprised if the issue is caused by using of this very
new interface. But it would be an easy thing...

> 
>     Currently, a value of '1" is written to /sys/kernel/slab/<slab>/shrink
>     file to shrink the slab by flushing out all the per-cpu slabs and free
>     slabs in partial lists.  This can be useful to squeeze out a bit more
>     memory under extreme condition as well as making the active object
> counts
>     in /proc/slabinfo more accurate.
> 
>     This usually applies only to the root caches, as the SLUB_ME
>

Otherwise I bet on some race around s->kobj.state_in_sysfs .
It interesting that it reproduces on a single cpu i386 machine.
I really wonder what makes it different.

Dennis, can you, please, insert some debug printing into
sysfs_slab_remove_workfn()? I wonder if it's really called twice
and where exactly it panics?

Thanks!



      reply	other threads:[~2019-12-26 23:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-205937-27@https.bugzilla.kernel.org/>
2019-12-23 22:14 ` Andrew Morton
2019-12-24  3:45   ` Dennis Clarke
2019-12-26 21:41   ` Christopher Lameter
2019-12-26 23:58     ` Roman Gushchin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191226235801.GD22734@tower.dhcp.thefacebook.com \
    --to=guro@fb.com \
    --cc=akpm@linux-foundation.org \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=cai@lca.pw \
    --cc=cl@linux.com \
    --cc=dclarke@blastwave.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-mm@kvack.org \
    --cc=longman@redhat.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox