From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DB8C2D0D2 for ; Mon, 23 Dec 2019 17:16:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 47B1E20663 for ; Mon, 23 Dec 2019 17:16:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="u5iUfElI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47B1E20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C39B58E0008; Mon, 23 Dec 2019 12:16:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC30C8E0001; Mon, 23 Dec 2019 12:16:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A89FF8E0008; Mon, 23 Dec 2019 12:16:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 8F14C8E0001 for ; Mon, 23 Dec 2019 12:16:52 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 449F85840 for ; Mon, 23 Dec 2019 17:16:52 +0000 (UTC) X-FDA: 76297061064.06.talk09_3bed5d1b67745 X-HE-Tag: talk09_3bed5d1b67745 X-Filterd-Recvd-Size: 4252 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Dec 2019 17:16:51 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id j1so11046172lja.2 for ; Mon, 23 Dec 2019 09:16:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dTfBS4fITKFzG6PAS8ATAU7u+aCjkt2oPpsuRrixycQ=; b=u5iUfElIbmpzJQ1yQVWEGftTzsuGCvhwRo+XXRpfxlc24UlIXLpkqdGzozs53t8t3x 9lujbJoN6kImET9059Ei9FRqaiHScZjblCEvF7s2oFB7G8L+z87OBENNf5xxUz7mUCEN A+Ed2tB1cdl1VnxZc9BrsfEjyp9kAK3FYoKnmrxNjdska7j5Qgs9DQezJsxfN3yHWdN8 4nthlvfQOYBzKtngkNv6pTgC1w0w8dOopyLfWIDUq8TR2tvEpjUg6BbjKClXgNH46O7Y v0O8rCqj5TOOZWG2+XNvO1QEkDE6l1+DD8/3tzl5OMOaNyZX318bD4yfyBXO3/k5c6l8 P0Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dTfBS4fITKFzG6PAS8ATAU7u+aCjkt2oPpsuRrixycQ=; b=lCDeTTKmFA9C0wibbzcd/aNHYKTNBri07tmtBRIy02ka7/4o3YJQsU2fWsS5Tu0U3b PvkD6GIooNxf2wIB7VnN6/Qw5X9yCFlq/9f8cIA4r44j7khVvJ1bHhu8x5zMlKY5ByQ5 AiF+qIa8CEAmLZCY78NzsMzERBGn6uHP2kT9T/jU0ED8kGtPI2EsWRJc3QWGhQADGffF 1mM0DN6c7TD96KjEPJjMPm9dCtz0HLZnt4O7mF1+IithtRDLgmIniW20FoCzNXziQcmb rwQLTYPMobapJhmunr68ZsDuQ2c3+z8tNkq7B40OPAVbKQPY9+Q8O+XD0V63ESYvBG3v WQ5A== X-Gm-Message-State: APjAAAV5j/+t5Wu9KNnhKxGZQn97QMJA1WoKPIjVAy9BCZFbhDbtKdWx dZmbNaL8Ko8HwpKCg8EUWA5dzFcsQYg= X-Google-Smtp-Source: APXvYqxL78/VMVVRLcW3ypUi/8u2tCs7BjbA5hAXf2R1EWL6vgmdaElgpaEjplMKmwEsAaDOLhPypw== X-Received: by 2002:a05:651c:232:: with SMTP id z18mr16279221ljn.85.1577121409867; Mon, 23 Dec 2019 09:16:49 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id q13sm10461189ljj.63.2019.12.23.09.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Dec 2019 09:16:49 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id E4A0610133D; Mon, 23 Dec 2019 20:16:53 +0300 (+03) Date: Mon, 23 Dec 2019 20:16:53 +0300 From: "Kirill A. Shutemov" To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com Subject: Re: [PATCH] mm/rmap.c: split huge pmd when it really is Message-ID: <20191223171653.xy2ri52xymkwm3ov@box> References: <20191223022435.30653-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191223022435.30653-1-richardw.yang@linux.intel.com> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.020949, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 23, 2019 at 10:24:35AM +0800, Wei Yang wrote: > There are two cases to call try_to_unmap_one() with TTU_SPLIT_HUGE_PMD > set: > > * unmap_page() > * shrink_page_list() > > In both case, the page passed to try_to_unmap_one() is PageHead() of the > THP. If this page's mapping address in process is not HPAGE_PMD_SIZE > aligned, this means the THP is not mapped as PMD THP in this process. > This could happen when we do mremap() a PMD size range to an un-aligned > address. > > Currently, this case is handled by following check in __split_huge_pmd() > luckily. > > page != pmd_page(*pmd) > > This patch checks the address to skip some hard work. Do you see some measurable performance improvement? rmap is heavy enough and I expect this kind of overhead to be within noise level. I don't have anything agains the check, but it complicates the picture. And if we are going this path, it worth also check if the vma is long enough to hold huge page. And I don't see why the check cannot be done inside split_huge_pmd_address(). -- Kirill A. Shutemov