* [PATCH] mm, memcg: fix comment error about memory.low usage
@ 2019-12-23 8:56 Xu Yu
2019-12-23 16:52 ` Roman Gushchin
0 siblings, 1 reply; 2+ messages in thread
From: Xu Yu @ 2019-12-23 8:56 UTC (permalink / raw)
To: cgroups; +Cc: linux-mm, hannes, mhocko, vdavydov.dev
When memory.current > memory.low, the usage of memory.low should be the
value of memory.low, not 0.
Fix and simplify the equation in comments.
Signed-off-by: Xu Yu <xuyu@linux.alibaba.com>
---
mm/memcontrol.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index c5b5f74..def95a5 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -6236,9 +6236,7 @@ struct cgroup_subsys memory_cgrp_subsys = {
* elow = min( memory.low, parent->elow * ------------------ ),
* siblings_low_usage
*
- * | memory.current, if memory.current < memory.low
- * low_usage = |
- * | 0, otherwise.
+ * low_usage = min( memory.current, memory.low )
*
*
* Such definition of the effective memory.low provides the expected
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm, memcg: fix comment error about memory.low usage
2019-12-23 8:56 [PATCH] mm, memcg: fix comment error about memory.low usage Xu Yu
@ 2019-12-23 16:52 ` Roman Gushchin
0 siblings, 0 replies; 2+ messages in thread
From: Roman Gushchin @ 2019-12-23 16:52 UTC (permalink / raw)
To: Xu Yu; +Cc: cgroups, linux-mm, hannes, mhocko, vdavydov.dev
On Mon, Dec 23, 2019 at 04:56:56PM +0800, Xu Yu wrote:
> When memory.current > memory.low, the usage of memory.low should be the
> value of memory.low, not 0.
>
> Fix and simplify the equation in comments.
Hello, Xu!
There is a pending patchset from Johannes, which performs a significant rework
of this code: https://lkml.org/lkml/2019/12/19/1272 .
Please, take a look.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-23 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-23 8:56 [PATCH] mm, memcg: fix comment error about memory.low usage Xu Yu
2019-12-23 16:52 ` Roman Gushchin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox