From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD31C2D0CD for ; Wed, 18 Dec 2019 21:45:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DBF9B2176D for ; Wed, 18 Dec 2019 21:45:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBF9B2176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7A9208E0140; Wed, 18 Dec 2019 16:45:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7591B8E00F5; Wed, 18 Dec 2019 16:45:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BCA98E0140; Wed, 18 Dec 2019 16:45:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 569DB8E00F5 for ; Wed, 18 Dec 2019 16:45:35 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id E8DCD8249980 for ; Wed, 18 Dec 2019 21:45:34 +0000 (UTC) X-FDA: 76279594188.11.vein07_4dc4dbf785939 X-HE-Tag: vein07_4dc4dbf785939 X-Filterd-Recvd-Size: 2055 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Dec 2019 21:45:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 96540AD5D; Wed, 18 Dec 2019 21:45:32 +0000 (UTC) Date: Wed, 18 Dec 2019 22:45:31 +0100 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Dave Hansen Cc: Sandipan Das , shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org, linux-arch@vger.kernel.org, fweimer@redhat.com, x86@kernel.org, linuxram@us.ibm.com, mhocko@kernel.org, linux-mm@kvack.org, mingo@redhat.com, aneesh.kumar@linux.ibm.com, bauerman@linux.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v15 06/23] selftests/vm/pkeys: Typecast the pkey register Message-ID: <20191218214531.GI4113@kitsune.suse.cz> References: <719ec65756a64cc03e8464a9c6da51c4519d2389.1576645161.git.sandipan@linux.ibm.com> <5b6c3f8a-9d2f-2534-c072-89f130ce110f@intel.com> <20191218205905.GG4113@kitsune.suse.cz> <15c3b6cc-d8da-9a32-da6a-4c3990f48994@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <15c3b6cc-d8da-9a32-da6a-4c3990f48994@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 18, 2019 at 01:01:46PM -0800, Dave Hansen wrote: > On 12/18/19 12:59 PM, Michal Such=E1nek wrote: > >> I'd really just rather do %016lx *everywhere* than sprinkle the > >> PKEY_REG_FMTs around. > > Does lx work with u32 without warnings? >=20 > Either way, I'd be happy to just make the x86 one u64 to make the whole > thing look more sane, So long as it still works with u64 on x86 it should be pretty future-proof. Does not look like we are getting 128bit registers for anything but math units any time soon. Thanks Michal