From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 660ABC43603 for ; Wed, 18 Dec 2019 13:58:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 310382176D for ; Wed, 18 Dec 2019 13:58:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 310382176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B4FE28E010F; Wed, 18 Dec 2019 08:57:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B01088E00F5; Wed, 18 Dec 2019 08:57:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A16A38E010F; Wed, 18 Dec 2019 08:57:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 891C68E00F5 for ; Wed, 18 Dec 2019 08:57:59 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 1F83F3D15 for ; Wed, 18 Dec 2019 13:57:59 +0000 (UTC) X-FDA: 76278415878.14.songs34_45a8717cad300 X-HE-Tag: songs34_45a8717cad300 X-Filterd-Recvd-Size: 3812 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Dec 2019 13:57:58 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id d73so1941925wmd.1 for ; Wed, 18 Dec 2019 05:57:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pCsuWU4HWowCBBiSnSWMn5G6gwMjvZ2EZc/rIekVAJM=; b=A0PkGDQOJ534ZTwOfeityyx7pSAzQzKBrkGSQynUOEkmBVCTvGZvFqHgUMukGgiddR vzSwrwC/EKD0Ct8DLGFCuOrBkf1ytAglyzsIeiGt2d4KQobbGxYtpZolTuKekwI5dm5n Ku6M6hu6MvIZ7qbWREFhVDpPa++JPQrfwGYc2LmcQO+aj5+K6Pn2+is57h9RKuYijgJe HooCU3GNg927CSSbl3WDJi5FYhR0HPJ2rCEKOpgWWxrIUUrDDxIdrBibQDtDo7CHynBr Y52z0nLjPxTQH7202qw/yNn7Ym68+W/zBsLytzpGfjfVsFzjHaFbwf7cb2SqcSWf595V vefw== X-Gm-Message-State: APjAAAXfsIxOVjjLCeBUX9Rb29IFzKCSFEWQiXv3WFsiiUBiQuTXfkCO XTcP/SnvOkX5eNwbcMs19dc= X-Google-Smtp-Source: APXvYqw3ofxfP1JoJp+brrKHwVfq8aEOnoOXYziPzSeicR3YmkDvybmUbu5EXKRypu0PMwfcYr0j8Q== X-Received: by 2002:a7b:c934:: with SMTP id h20mr3398387wml.103.1576677477413; Wed, 18 Dec 2019 05:57:57 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id z3sm2572944wrs.94.2019.12.18.05.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 05:57:56 -0800 (PST) Date: Wed, 18 Dec 2019 14:57:55 +0100 From: Michal Hocko To: Hillf Danton Cc: linux-kernel , linux-mm , Tejun Heo , Lai Jiangshan Subject: Re: [RFC] workqueue: dexpose worker Message-ID: <20191218135755.GC28111@dhcp22.suse.cz> References: <20191218035945.16180-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191218035945.16180-1-hdanton@sina.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.011282, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: You probably wanted to Cc maintainers. On Wed 18-12-19 11:59:45, Hillf Danton wrote: > > It does not make much sense to expose worker, workqueue's internal > object, to outsiders, and whatever field inside worker as well. > Nor does worker pool rather than workqueue and work. But I have to say that this doesn't really make much sense to me. What is the problem you are trying to solve? current_is_executing is a really ambiguous name without any relation to WQ. Also this seems like a pointless code churn to me. Anyway for maintainers to judge. > > Signed-off-by: Hillf Danton > --- > > --- a/kernel/workqueue_internal.h > +++ b/kernel/workqueue_internal.h > @@ -69,6 +69,13 @@ static inline struct worker *current_wq_ > return NULL; > } > > +static inline bool current_is_executing(work_func_t func) > +{ > + struct worker *worker = current_wq_worker(); > + > + return worker && worker->current_func == func; > +} > + > /* > * Scheduler hooks for concurrency managed workqueue. Only to be used from > * sched/ and workqueue.c. > --- a/kernel/async.c > +++ b/kernel/async.c > @@ -327,8 +327,6 @@ EXPORT_SYMBOL_GPL(async_synchronize_cook > */ > bool current_is_async(void) > { > - struct worker *worker = current_wq_worker(); > - > - return worker && worker->current_func == async_run_entry_fn; > + return current_is_executing(async_run_entry_fn); > } > EXPORT_SYMBOL_GPL(current_is_async); > -- Michal Hocko SUSE Labs