From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB93C43603 for ; Wed, 18 Dec 2019 01:57:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D81D2176D for ; Wed, 18 Dec 2019 01:57:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="iJejrBuo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D81D2176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD0CD8E00C3; Tue, 17 Dec 2019 20:57:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C82058E0079; Tue, 17 Dec 2019 20:57:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B49AC8E00C3; Tue, 17 Dec 2019 20:57:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 9EA208E0079 for ; Tue, 17 Dec 2019 20:57:58 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 394572C1E for ; Wed, 18 Dec 2019 01:57:58 +0000 (UTC) X-FDA: 76276601436.30.hose48_286b18667db02 X-HE-Tag: hose48_286b18667db02 X-Filterd-Recvd-Size: 4683 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Dec 2019 01:57:57 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBI1sKpQ039809; Wed, 18 Dec 2019 01:57:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=15neapn3hexipdYPtu5c6du1j7tBf71ljZTqTLp/yK0=; b=iJejrBuoxC49PzOrv7wgVmtR8pKVwk5BP4lVklbYqjswXAz39Nd8KtfMf+SzSRk7x+dr 0cAbrExT8Un1uODdNwoj0PuuHfTsRgPrnmVQcMv9Dus9S4eQrgOryU/vbg2JMwEOjSfI 1mhX/uAzxcfCWp3QADsGL4/Pl4EPWdEDXZ549iW1NcImKPM34YSHESNYYBL+2GAb4Xu9 jR1H5dLad3KVgnDq6fAfKpdSqEKvmTH4s/Fkb//gVP4W4Z1YCVjV4B/PmboBq9wBgKXa r3zbHJxYG7DbmBQAcmEfNX0k2pTcuWFz+BMdmYeH0dpQCcY65GmSsRN2gMN2N5oTDJIV Pg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2wvrcrad1n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Dec 2019 01:57:50 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBI1sAuJ061303; Wed, 18 Dec 2019 01:57:50 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2wxm5p7r7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Dec 2019 01:57:49 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xBI1vl7a007227; Wed, 18 Dec 2019 01:57:47 GMT Received: from localhost (/10.159.137.228) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 17 Dec 2019 17:57:47 -0800 Date: Tue, 17 Dec 2019 17:57:46 -0800 From: "Darrick J. Wong" To: Jens Axboe , '@magnolia.kvack.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, willy@infradead.org, clm@fb.com, torvalds@linux-foundation.org, david@fromorbit.com Subject: Re: [PATCH 6/6] xfs: don't do delayed allocations for uncached buffered writes Message-ID: <20191218015746.GB12752@magnolia> References: <20191217143948.26380-1-axboe@kernel.dk> <20191217143948.26380-7-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191217143948.26380-7-axboe@kernel.dk> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9474 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912180014 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9474 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=-1004 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912180014 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 17, 2019 at 07:39:48AM -0700, Jens Axboe wrote: > This data is going to be written immediately, so don't bother trying > to do delayed allocation for it. > > Suggested-by: Dave Chinner > Signed-off-by: Jens Axboe Looks reasonable once all the previous patches go in, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_iomap.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c > index 28e2d1f37267..d0cd4a05d59f 100644 > --- a/fs/xfs/xfs_iomap.c > +++ b/fs/xfs/xfs_iomap.c > @@ -847,8 +847,11 @@ xfs_buffered_write_iomap_begin( > int allocfork = XFS_DATA_FORK; > int error = 0; > > - /* we can't use delayed allocations when using extent size hints */ > - if (xfs_get_extsz_hint(ip)) > + /* > + * Don't do delayed allocations when using extent size hints, or > + * if we were asked to do uncached buffered writes. > + */ > + if (xfs_get_extsz_hint(ip) || (flags & IOMAP_UNCACHED)) > return xfs_direct_write_iomap_begin(inode, offset, count, > flags, iomap, srcmap); > > -- > 2.24.1 >