From: Wei Yang <richardw.yang@linux.intel.com>
To: Qian Cai <cai@lca.pw>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove dead code totalram_pages_set()
Date: Wed, 18 Dec 2019 08:50:42 +0800 [thread overview]
Message-ID: <20191218005042.GB23703@richard> (raw)
In-Reply-To: <8456A27B-5F32-4BED-B826-27B17E87AA81@lca.pw>
On Tue, Dec 17, 2019 at 07:48:09AM -0500, Qian Cai wrote:
>
>
>> On Dec 17, 2019, at 1:44 AM, Wei Yang <richardw.yang@linux.intel.com> wrote:
>>
>> No one use totalram_pages_set(), just remote it.
>
>It is unlikely that this is unintentional, but can you figure out which commit removed the last caller just in case?
Took a look into the history. This function is introduced in
commit 'ca79b0c211af' (mm: convert totalram_pages and totalhigh_pages
variables to atomic)
Even in this commit, no one use this function.
Will include this in next version.
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-12-18 0:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 6:44 Wei Yang
2019-12-17 11:01 ` David Hildenbrand
2019-12-18 0:48 ` Wei Yang
2019-12-17 12:48 ` Qian Cai
2019-12-18 0:50 ` Wei Yang [this message]
2019-12-18 1:04 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218005042.GB23703@richard \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox