From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B558CC2D0BF for ; Wed, 18 Dec 2019 00:48:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E5CF2176D for ; Wed, 18 Dec 2019 00:48:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E5CF2176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C92578E00B6; Tue, 17 Dec 2019 19:48:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C415F8E0079; Tue, 17 Dec 2019 19:48:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B56868E00B6; Tue, 17 Dec 2019 19:48:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 9FF7A8E0079 for ; Tue, 17 Dec 2019 19:48:20 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 6F4842DFA for ; Wed, 18 Dec 2019 00:48:20 +0000 (UTC) X-FDA: 76276425960.10.town75_e850b34d6950 X-HE-Tag: town75_e850b34d6950 X-Filterd-Recvd-Size: 2351 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Dec 2019 00:48:19 +0000 (UTC) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 16:48:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="417036239" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga006.fm.intel.com with ESMTP; 17 Dec 2019 16:48:17 -0800 Date: Wed, 18 Dec 2019 08:48:15 +0800 From: Wei Yang To: David Hildenbrand , g@richard.kvack.org Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: remove dead code totalram_pages_set() Message-ID: <20191218004815.GA23703@richard> Reply-To: Wei Yang References: <20191217064401.18047-1-richardw.yang@linux.intel.com> <64835f9c-3ead-ef6e-3eeb-5de2b9725fa2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64835f9c-3ead-ef6e-3eeb-5de2b9725fa2@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 17, 2019 at 12:01:11PM +0100, David Hildenbrand wrote: >On 17.12.19 07:44, Wei Yang wrote: >> No one use totalram_pages_set(), just remote it. > >s/use/uses/ >s/remote/remove/ > Thanks, my bad. >> >> Signed-off-by: Wei Yang >> --- >> include/linux/mm.h | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 74232b28949b..4cf023c4c6b3 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -70,11 +70,6 @@ static inline void totalram_pages_add(long count) >> atomic_long_add(count, &_totalram_pages); >> } >> >> -static inline void totalram_pages_set(long val) >> -{ >> - atomic_long_set(&_totalram_pages, val); >> -} >> - >> extern void * high_memory; >> extern int page_cluster; >> >> > >Reviewed-by: David Hildenbrand > >-- >Thanks, > >David / dhildenb -- Wei Yang Help you, Help me