From: Wei Yang <richardw.yang@linux.intel.com>
To: David Hildenbrand <david@redhat.com>, g@richard.kvack.org
Cc: Wei Yang <richardw.yang@linux.intel.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove dead code totalram_pages_set()
Date: Wed, 18 Dec 2019 08:48:15 +0800 [thread overview]
Message-ID: <20191218004815.GA23703@richard> (raw)
In-Reply-To: <64835f9c-3ead-ef6e-3eeb-5de2b9725fa2@redhat.com>
On Tue, Dec 17, 2019 at 12:01:11PM +0100, David Hildenbrand wrote:
>On 17.12.19 07:44, Wei Yang wrote:
>> No one use totalram_pages_set(), just remote it.
>
>s/use/uses/
>s/remote/remove/
>
Thanks, my bad.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> ---
>> include/linux/mm.h | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index 74232b28949b..4cf023c4c6b3 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -70,11 +70,6 @@ static inline void totalram_pages_add(long count)
>> atomic_long_add(count, &_totalram_pages);
>> }
>>
>> -static inline void totalram_pages_set(long val)
>> -{
>> - atomic_long_set(&_totalram_pages, val);
>> -}
>> -
>> extern void * high_memory;
>> extern int page_cluster;
>>
>>
>
>Reviewed-by: David Hildenbrand <david@redhat.com>
>
>--
>Thanks,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-12-18 0:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 6:44 Wei Yang
2019-12-17 11:01 ` David Hildenbrand
2019-12-18 0:48 ` Wei Yang [this message]
2019-12-17 12:48 ` Qian Cai
2019-12-18 0:50 ` Wei Yang
2019-12-18 1:04 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218004815.GA23703@richard \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=g@richard.kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox