From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3245BC43603 for ; Tue, 17 Dec 2019 15:32:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E99EE24655 for ; Tue, 17 Dec 2019 15:32:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="S8MaiI4Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E99EE24655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 817A38E0088; Tue, 17 Dec 2019 10:32:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C7668E0079; Tue, 17 Dec 2019 10:32:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B5E18E0088; Tue, 17 Dec 2019 10:32:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 4CDE58E0079 for ; Tue, 17 Dec 2019 10:32:16 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 1081C2C14 for ; Tue, 17 Dec 2019 15:32:16 +0000 (UTC) X-FDA: 76275024672.22.fowl21_6b028de087a10 X-HE-Tag: fowl21_6b028de087a10 X-Filterd-Recvd-Size: 3389 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Dec 2019 15:32:15 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id u2so3651286wmc.3 for ; Tue, 17 Dec 2019 07:32:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Jr1dFn2z1P4MsCtmqPO29rPINYbqBsWbvl95K0lo3qY=; b=S8MaiI4Z66kRaGiMhNUN5izJT/aLZ2SBTEoB/9/RfJGT+OLbgVeTb6CrjMk2gwEaEM iApa7Msqy8sCczZO6v7wBKLtLk0o2ps7CXJQeGl93tTlLgTx8zPCahSxnVSmPwoBo6gP QBL1DbYqpLBffIsBuRFiZz/01B9trZgNwndZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Jr1dFn2z1P4MsCtmqPO29rPINYbqBsWbvl95K0lo3qY=; b=bvf01LCWw8aMcc5ZPiBkRLZpLvpq55uCib971qFhTURWV0LYdzWMISxNZklLjGMEzG NgwRlaeTvJZWrxPZdwPuzyELNetT8F/TzK9ctUjCQB3BJCHo9ACLaP7rTps0AgxMxiq+ kis15NCRXpmFsY9Y8gtaK1PcgX6MeARPLx5dZJ9eyenve5+LZ/FbFxHFeUezZmkaVmEO fuKDsK1GIsHaeeHQbXVXIfoW8EPk79xMndZC4bDU4lPXrZBCrnVUQJUcz6r36BHcQRlX SlIU9+hntVGiHYeqKf+lrESLkOHEWgPDQ31Nkp5W3oRhr4lDxwF4yqj2AqJgYC+d0/iK r9Yw== X-Gm-Message-State: APjAAAUahmZp994HlQgCr5RCBAGtmLt1MoO+Gv+hrnzz3YWV9LhdIOM1 JWW1wPX7rSYnfbu0vdSsYYoKXg== X-Google-Smtp-Source: APXvYqzjU+JjhEXh9jQai0fkom/Xh8F1LV3x9ndI4wUqXHm32YZsa8QsrQNMx4xEzc2db+PVzyZe/Q== X-Received: by 2002:a1c:1bc3:: with SMTP id b186mr6133038wmb.79.1576596734150; Tue, 17 Dec 2019 07:32:14 -0800 (PST) Received: from localhost ([2620:10d:c092:180::1:f184]) by smtp.gmail.com with ESMTPSA id f9sm3320285wmb.4.2019.12.17.07.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 07:32:13 -0800 (PST) Date: Tue, 17 Dec 2019 15:32:13 +0000 From: Chris Down To: Michal Hocko Cc: Qian Cai , Kuninori Morimoto , Johannes Weiner , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU Message-ID: <20191217153213.GC136178@chrisdown.name> References: <20191217135440.GB58496@chrisdown.name> <392D7C59-5538-4A9B-8974-DB0B64880C2C@lca.pw> <20191217144652.GA7272@dhcp22.suse.cz> <20191217150921.GA136178@chrisdown.name> <20191217151931.GD7272@dhcp22.suse.cz> <20191217152814.GB136178@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191217152814.GB136178@chrisdown.name> X-Bogosity: Ham, tests=bogofilter, spamicity=0.088453, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Chris Down writes: >Maybe Qian is right and we should just ignore such patches, but I >think that comes with its own risks that we will alienate perfectly >well intentioned new contributors to mm without them having any idea >why we did that. s/Qian/Cai/ :-)