From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4585CC2D0CD for ; Tue, 17 Dec 2019 15:19:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E81121582 for ; Tue, 17 Dec 2019 15:19:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E81121582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB8568E0086; Tue, 17 Dec 2019 10:19:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A69E68E0079; Tue, 17 Dec 2019 10:19:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E5F8E0086; Tue, 17 Dec 2019 10:19:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 822D68E0079 for ; Tue, 17 Dec 2019 10:19:34 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2C80640D7 for ; Tue, 17 Dec 2019 15:19:34 +0000 (UTC) X-FDA: 76274992668.01.basin79_8dae0fadee73e X-HE-Tag: basin79_8dae0fadee73e X-Filterd-Recvd-Size: 3229 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Dec 2019 15:19:33 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id p17so3610667wma.1 for ; Tue, 17 Dec 2019 07:19:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4zEQ83F2qGoC/F92fA9F7HDEhihvKc7tNEjbPfQsODw=; b=mlRfttYZ732c2fGxUm2Iz7PsaFFR2YIyXluXBBVO+o6JEh6tND4KPZDdn0ALS6RNiA PfMDw5QKuHBpej4RoVgGsAiKCor/qkgb8ZypdK3nKYVzwha9FDbWCGv8IG16iwNd+VsX w38RqrjwosjHMRAVqukMmue80zPAHjO0tBcs96oOW96Giss83DuU8PVU5Phx2/DrRzsD uJbfDfBnN1HJZILXwQ2XEuLGhqMWBbLcDiVfipeIa50ryE50YA4b/X8jjK3OQY5Ix+Hw mlEmguhsOVyLYlNebJEBYLLFe11x3kPiLHYApH180XkcBpUwZ1UAor7IlIpclSQ92kWG 8Zrw== X-Gm-Message-State: APjAAAUvbauSKasZqo50wnSLbCDPWqs8Gu8rM1vEt79gG+GQQVj7+oGl DovyqcP1JHtJIC31F95R478= X-Google-Smtp-Source: APXvYqztX/vQknATUnJPGuoDhEQMMAkKQ4QrJJ9k4b4XynST/j+I8Qhac3CMutXvlAw3+85wIvzcjA== X-Received: by 2002:a1c:ddc5:: with SMTP id u188mr5787814wmg.83.1576595972595; Tue, 17 Dec 2019 07:19:32 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id a9sm3347964wmm.15.2019.12.17.07.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 07:19:31 -0800 (PST) Date: Tue, 17 Dec 2019 16:19:31 +0100 From: Michal Hocko To: Chris Down Cc: Qian Cai , Kuninori Morimoto , Johannes Weiner , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU Message-ID: <20191217151931.GD7272@dhcp22.suse.cz> References: <20191217135440.GB58496@chrisdown.name> <392D7C59-5538-4A9B-8974-DB0B64880C2C@lca.pw> <20191217144652.GA7272@dhcp22.suse.cz> <20191217150921.GA136178@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191217150921.GA136178@chrisdown.name> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 17-12-19 15:09:21, Chris Down wrote: [...] > (Side note: I'm moderately baffled that a tightly scoped __maybe_unused is > considered sinister but somehow disabling -Wunused-function is on the table > :-)) Well, I usually do not like to see __maybe_unused because that is prone to bit-rot and loses its usefulness. Looking into the recent git logs most -Wunused-function led to the code removal (which is really good but the compiler is likely to do that already so the overall impact is not that large) or more ifdefery. I do not really see many instance of __maybe_unused. -- Michal Hocko SUSE Labs