From: Michal Hocko <mhocko@kernel.org>
To: Chris Down <chris@chrisdown.name>
Cc: Qian Cai <cai@lca.pw>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU
Date: Tue, 17 Dec 2019 16:19:31 +0100 [thread overview]
Message-ID: <20191217151931.GD7272@dhcp22.suse.cz> (raw)
In-Reply-To: <20191217150921.GA136178@chrisdown.name>
On Tue 17-12-19 15:09:21, Chris Down wrote:
[...]
> (Side note: I'm moderately baffled that a tightly scoped __maybe_unused is
> considered sinister but somehow disabling -Wunused-function is on the table
> :-))
Well, I usually do not like to see __maybe_unused because that is prone
to bit-rot and loses its usefulness. Looking into the recent git logs
most -Wunused-function led to the code removal (which is really good
but the compiler is likely to do that already so the overall impact is
not that large) or more ifdefery. I do not really see many instance of
__maybe_unused.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-12-17 15:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 6:47 Kuninori Morimoto
2019-12-17 9:53 ` Michal Hocko
2019-12-17 13:54 ` Chris Down
2019-12-17 14:16 ` Qian Cai
2019-12-17 14:37 ` Chris Down
2019-12-17 15:09 ` Qian Cai
2019-12-17 14:46 ` Michal Hocko
2019-12-17 15:04 ` Qian Cai
2019-12-17 15:13 ` Michal Hocko
2019-12-17 15:17 ` Qian Cai
2019-12-17 15:09 ` Chris Down
2019-12-17 15:19 ` Michal Hocko [this message]
2019-12-17 15:28 ` Chris Down
2019-12-17 15:32 ` Chris Down
2019-12-17 15:34 ` Qian Cai
2019-12-17 15:46 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217151931.GD7272@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=hannes@cmpxchg.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox