From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A61C43603 for ; Tue, 17 Dec 2019 15:00:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D8D8218AC for ; Tue, 17 Dec 2019 15:00:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D8D8218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E24CE8E007D; Tue, 17 Dec 2019 09:59:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD35D8E0079; Tue, 17 Dec 2019 09:59:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE93E8E007D; Tue, 17 Dec 2019 09:59:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id B4FE88E0079 for ; Tue, 17 Dec 2019 09:59:59 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 595A7180AD806 for ; Tue, 17 Dec 2019 14:59:59 +0000 (UTC) X-FDA: 76274943318.21.order72_743fc4cdc5e58 X-HE-Tag: order72_743fc4cdc5e58 X-Filterd-Recvd-Size: 3374 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Dec 2019 14:59:58 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id g17so11650205wro.2 for ; Tue, 17 Dec 2019 06:59:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2RPvkS3wiyM/cXFFWnnKAmIdzbhl6b/6rYSNRYDRpP8=; b=ODAH/9kXZrbReI9N0gq+eRf0nywBm4NRg+6RF0eBDCl8eIQFHbJm1l4XyP8s7yd5Jd HFY6N/+/bbvslWJRHA/8qnIC67ciwNkwpOEfdwtmRiWny1hDTMcCW5ig0eTkA72PYlO0 gGlNsChimQzUIFohlb/9Dcm8jh8zy1HaD+oK2T2H2YXC9H/oKevALKUGfiYpvpOGJTIV D2ZQaLAdPazw0qtW3FWUL2xWgP22jZPVP44MxNOHGUEwBKtOosv+7mDG21Sde8OmG6qO 6539HUo6B4eCvgMNuW1heO4BA5IK5ELRHxXo65/H6m3mBA6Am21XDtMlqHTcaYFJTGJP dITg== X-Gm-Message-State: APjAAAUnzMf2rfNipPnP9vplrGyTgAyxbg4b37As83ZYxrUBgaF+Fp7m DAebqdDzV4jz7+gnPWNPu4E= X-Google-Smtp-Source: APXvYqwToPCZf/hfVwtsEh/E6+vprZwTG2iGnaekZ116daSVUTobkTHQ+iBS7F0gfpLxiRWdwBWXFw== X-Received: by 2002:a5d:6144:: with SMTP id y4mr37413605wrt.15.1576594797705; Tue, 17 Dec 2019 06:59:57 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id f1sm25682801wro.85.2019.12.17.06.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 06:59:56 -0800 (PST) Date: Tue, 17 Dec 2019 15:59:56 +0100 From: Michal Hocko To: Waiman Long Cc: Mike Kravetz , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Davidlohr Bueso , Andi Kleen , "Aneesh Kumar K.V" Subject: Re: [PATCH v2] mm/hugetlb: Defer freeing of huge pages if in non-task context Message-ID: <20191217145956.GB7272@dhcp22.suse.cz> References: <20191217012508.31495-1-longman@redhat.com> <20191217093143.GC31063@dhcp22.suse.cz> <4bb217ac-d80a-12b8-839f-2db9ced2636b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4bb217ac-d80a-12b8-839f-2db9ced2636b@redhat.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 17-12-19 09:06:31, Waiman Long wrote: > On 12/17/19 4:31 AM, Michal Hocko wrote: > > On Mon 16-12-19 20:25:08, Waiman Long wrote: [...] > >> + pr_debug("HugeTLB: free_hpage_workfn() frees %d huge page(s)\n", cnt); > > Why do we need the debugging message here? > > It is there just to verify that the workfn is properly activated and > frees the huge page. This message won't be printed by default. I can > remove it if you guys don't really want a debug statement here. Yes, drop it please. We are not adding debugging messages unless they are really actionable. If this is a sign of a bug then put a WARN_ONCE or somethin like that. But with a simple code like this it doesn't really seem to be suitable IMHO. Thanks! -- Michal Hocko SUSE Labs