From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9FEC43603 for ; Tue, 17 Dec 2019 02:16:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FC522176D for ; Tue, 17 Dec 2019 02:16:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fMahm2K5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FC522176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90C6A8E003B; Mon, 16 Dec 2019 21:16:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BD988E002F; Mon, 16 Dec 2019 21:16:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D3168E003B; Mon, 16 Dec 2019 21:16:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 674D78E002F for ; Mon, 16 Dec 2019 21:16:25 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 0730E37F1 for ; Tue, 17 Dec 2019 02:16:25 +0000 (UTC) X-FDA: 76273019130.12.cave56_8f28bdb1b8d18 X-HE-Tag: cave56_8f28bdb1b8d18 X-Filterd-Recvd-Size: 4642 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Dec 2019 02:16:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=siGlAtwbpMtn2+e/O7hKM+nw0EWpzij1iF2dGkh6S28=; b=fMahm2K5a4Q9AU7WAk02csbb8w kPQUQkYGI1oxLG13qBOQYj40/hcOw6UrbIKgqlWAymUgbivUWBlJBr0EBJQYEtGKsLM8iyozgPkhR FPjoylR+LfIYOO09S4gFDvvCUKRYE/fh7bNn6HwUfg9TmcvJAjXXkTRfLfGT0whTBbTyUtZUxfZag +0zeiBvJK7mPFXM2IspiWLrfiiZq7641o5OVTZLszsOX8JG98YfVlKnY82iYtBwOt/maBbZGdzFdP e1qJxVzjYr8raPVoeo/pMmCTp9aG32t41zTdk8q0B6hkXf3iUmfVdwvYGFDRVoEXOHUOfvmsgjjNm v/67Uo4A==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ih2PF-0007pq-5W; Tue, 17 Dec 2019 02:16:13 +0000 Date: Mon, 16 Dec 2019 18:16:13 -0800 From: Matthew Wilcox To: Alex Shi Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, shakeelb@google.com, hannes@cmpxchg.org, Michal Hocko , Vladimir Davydov , Roman Gushchin , Chris Down , Thomas Gleixner , Vlastimil Babka , Qian Cai , Andrey Ryabinin , "Kirill A. Shutemov" , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrea Arcangeli , David Rientjes , "Aneesh Kumar K.V" , swkhack , "Potyra, Stefan" , Mike Rapoport , Stephen Rothwell , Colin Ian King , Jason Gunthorpe , Mauro Carvalho Chehab , Peng Fan , Nikolay Borisov , Ira Weiny , Kirill Tkhai , Yafang Shao Subject: Re: [PATCH v6 02/10] mm/lru: replace pgdat lru_lock with lruvec lock Message-ID: <20191217021613.GB32169@bombadil.infradead.org> References: <1576488386-32544-1-git-send-email-alex.shi@linux.alibaba.com> <1576488386-32544-3-git-send-email-alex.shi@linux.alibaba.com> <20191216121427.GZ32169@bombadil.infradead.org> <286c11c2-480f-37d6-e9fe-91822f862cd6@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <286c11c2-480f-37d6-e9fe-91822f862cd6@linux.alibaba.com> User-Agent: Mutt/1.12.1 (2019-06-15) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 17, 2019 at 09:30:13AM +0800, Alex Shi wrote: > =E5=9C=A8 2019/12/16 =E4=B8=8B=E5=8D=888:14, Matthew Wilcox =E5=86=99=E9= =81=93: > > On Mon, Dec 16, 2019 at 05:26:18PM +0800, Alex Shi wrote: > >> -static void lock_page_lru(struct page *page, int *isolated) > >> +static struct lruvec *lock_page_lru(struct page *page, int *isolate= d) > >> { > >> - pg_data_t *pgdat =3D page_pgdat(page); > >> + struct lruvec *lruvec =3D lock_page_lruvec_irq(page); > >> =20 > >> - spin_lock_irq(&pgdat->lru_lock); > >> if (PageLRU(page)) { > >> - struct lruvec *lruvec; > >> =20 > >> - lruvec =3D mem_cgroup_page_lruvec(page, pgdat); > >> ClearPageLRU(page); > >> del_page_from_lru_list(page, lruvec, page_lru(page)); > >> *isolated =3D 1; > >> } else > >> *isolated =3D 0; > >> + > >> + return lruvec; > >> } > >=20 > > You still didn't fix this function. Go back and look at my comment f= rom > > the last time you sent this patch set. > >=20 >=20 > Sorry for the misunderstanding. I guess what your want is fold the patc= h 9th into this, is that right? > Any comments for the 9th patch? I didn't get as far as looking at the ninth patch because I saw this one was wrong and stopped looking. This is not the first time *with this patch set* that you've been told to *fix the patch*, not submit something that's broken and fix it in a later patch. I'll look at patch 9 later.