From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Li Xinhai <lixinhai.lxh@gmail.com>
Cc: linux-mm@kvack.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] mm/memory.c: avoid repeated set_page_dirty in fault_dirty_shared_page
Date: Thu, 12 Dec 2019 19:55:20 +0300 [thread overview]
Message-ID: <20191212165520.g6rpzvvlyi5wszw6@box> (raw)
In-Reply-To: <1576164078-28402-1-git-send-email-lixinhai.lxh@gmail.com>
On Thu, Dec 12, 2019 at 11:21:18PM +0800, Li Xinhai wrote:
> When vm_ops->page_mkwrite is defined, and called from wp_page_shared and
> do_shared_fault, the set_page_dirty must already called by page_mkwrite.
Must? Do all ->page_mkwrite implementation do this?
> @@ -3645,7 +3646,7 @@ static vm_fault_t do_shared_fault(struct vm_fault *vmf)
> * Check if the backing address space wants to know that the page is
> * about to become writable
> */
> - if (vma->vm_ops->page_mkwrite) {
> + if (vma->vm_ops && vma->vm_ops->page_mkwrite) {
vma->vm_ops is always non-NULL here.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2019-12-12 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 15:21 Li Xinhai
2019-12-12 15:35 ` David Hildenbrand
2019-12-12 16:55 ` Kirill A. Shutemov [this message]
2019-12-13 7:28 ` lixinhai.lxh
2019-12-13 17:50 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212165520.g6rpzvvlyi5wszw6@box \
--to=kirill@shutemov.name \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=lixinhai.lxh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox