From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86764C43603 for ; Thu, 12 Dec 2019 09:32:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 366C42173E for ; Thu, 12 Dec 2019 09:32:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="k3hTXrSj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 366C42173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DEAA66B36C4; Thu, 12 Dec 2019 04:32:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D9B8C6B36C5; Thu, 12 Dec 2019 04:32:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB20D6B36C6; Thu, 12 Dec 2019 04:32:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id B69026B36C4 for ; Thu, 12 Dec 2019 04:32:02 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 4FF41583A for ; Thu, 12 Dec 2019 09:32:02 +0000 (UTC) X-FDA: 76255972884.26.fall13_11b555b995c3a X-HE-Tag: fall13_11b555b995c3a X-Filterd-Recvd-Size: 4512 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Dec 2019 09:32:01 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBC9T5oq187122; Thu, 12 Dec 2019 09:32:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2019-08-05; bh=a1GqHR+4c4myOQBwgy8BTKWNKsrPluhqyOj7ViNl3Gk=; b=k3hTXrSjWv8JADKX827T5hsHTB+tKiaQIRkQV76Gnd1jzpEKtW24uI5uTLSh4OB9CWxY vwdJ7Cot82Yqob5kSAvE2RPp5TV1xbLAu5jit/eGyBAkG2S9++Wb5EKeJkexQwZBtPiu 67wyZVsoJ192FcLQl2FQySD+/fqpRc+BA13OFsbAowMhuCyYpAXCgOWLHcCgRGr4TddQ NA5UUQL+W14MhHvVlNsDz3kSncX2p5rmG4dAnPV6hblHQ26zWYoNaX42GvG5NCVdgxMy t5yZDKXvKmorNHZiNiy2OTTwLmTl5uGmxkX39iHjPjnhEMhMb1OAU5UrkqfsAwM+oZ/a gQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2wrw4nekre-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Dec 2019 09:32:00 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBC9SM2T124787; Thu, 12 Dec 2019 09:29:59 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2wu5csjgu8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Dec 2019 09:29:59 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xBC9TvaO016947; Thu, 12 Dec 2019 09:29:57 GMT Received: from kili.mountain (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 12 Dec 2019 01:29:56 -0800 Date: Thu, 12 Dec 2019 12:29:49 +0300 From: Dan Carpenter To: akpm@linux-foundation.org Cc: linux-mm@kvack.org Subject: [bug report] mm-add-apply_to_existing_pages-helper-fix Message-ID: <20191212092949.efpedkoshbehydfx@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=653 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912120068 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=714 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912120068 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Andrew Morton, The patch 3264ba9274f5: "mm-add-apply_to_existing_pages-helper-fix" from Dec 11, 2019, leads to the following static checker warning: mm/memory.c:2166 __apply_to_page_range() error: uninitialized symbol 'err'. mm/memory.c 2144 static int __apply_to_page_range(struct mm_struct *mm, unsigned long addr, 2145 unsigned long size, pte_fn_t fn, 2146 void *data, bool create) 2147 { 2148 pgd_t *pgd; 2149 unsigned long next; 2150 unsigned long end = addr + size; 2151 int err; 2152 2153 if (WARN_ON(addr >= end)) 2154 return -EINVAL; 2155 2156 pgd = pgd_offset(mm, addr); 2157 do { 2158 next = pgd_addr_end(addr, end); 2159 if (!create && pgd_none_or_clear_bad(pgd)) 2160 continue; ^^^^^^^^^ It feels unlikely that we would always hit this continue but Smatch complains. 2161 err = apply_to_p4d_range(mm, pgd, addr, next, fn, data, create); 2162 if (err) 2163 break; 2164 } while (pgd++, addr = next, addr != end); 2165 2166 return err; 2167 } regards, dan carpenter