From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55067C2D0C9 for ; Thu, 12 Dec 2019 06:37:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2C34922527 for ; Thu, 12 Dec 2019 06:37:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C34922527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stgolabs.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B11CA6B3628; Thu, 12 Dec 2019 01:37:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC2DD6B3629; Thu, 12 Dec 2019 01:37:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D8256B362A; Thu, 12 Dec 2019 01:37:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 813716B3628 for ; Thu, 12 Dec 2019 01:37:19 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 328338249980 for ; Thu, 12 Dec 2019 06:37:19 +0000 (UTC) X-FDA: 76255532598.10.laugh52_5cf678be6b51d X-HE-Tag: laugh52_5cf678be6b51d X-Filterd-Recvd-Size: 1993 Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Dec 2019 06:37:18 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id DE03EB18D; Thu, 12 Dec 2019 06:37:16 +0000 (UTC) Date: Wed, 11 Dec 2019 22:30:50 -0800 From: Davidlohr Bueso To: Mike Kravetz , Waiman Long , Matthew Wilcox , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko Subject: Re: [PATCH v2] hugetlbfs: Disable softIRQ when taking hugetlb_lock Message-ID: <20191212063050.ufrpij6s6jkv7g7j@linux-p48b> Mail-Followup-To: Mike Kravetz , Waiman Long , Matthew Wilcox , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko References: <20191211194615.18502-1-longman@redhat.com> <4fbc39a9-2c9c-4c2c-2b13-a548afe6083c@oracle.com> <32d2d4f2-83b9-2e40-05e2-71cd07e01b80@redhat.com> <0fcce71f-bc20-0ea3-b075-46592c8d533d@oracle.com> <20191212060650.ftqq27ftutxpc5hq@linux-p48b> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191212060650.ftqq27ftutxpc5hq@linux-p48b> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Dec 2019, Davidlohr Bueso wrote: >Instead, just use a workqueue and do the free_huge_page() in regular >task context. Hmm so this is done unconditionally, perhaps we want to do this _only_ under irq just to avoid any workqueue overhead in the common case? if (unlikely(in_interrupt()) { workqueue free_huge_page } else { normal free_huge_page } Thanks, Davidlohr