From: Hillf Danton <hdanton@sina.com>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Hillf Danton <hdanton@sina.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [RFC 3/4] workqueue: reap dead pool workqueue on queuing work
Date: Thu, 12 Dec 2019 10:28:23 +0800 [thread overview]
Message-ID: <20191212022823.21144-1-hdanton@sina.com> (raw)
In-Reply-To: <20191211112229.22652-1-hdanton@sina.com>
On Wed, 11 Dec 2019 18:25:04 -0500 Daniel Jordan wrote:
> On Wed, Dec 11, 2019 at 07:22:29PM +0800, Hillf Danton wrote:
> > Release rcu lock to reap dead pool workqueue.
>
> What's to be gained by reaping the pwq (and possibly worker pool and wq) before
> __queue_work() retries? It'll just happen after the queueing finishes.
Releasing rcu lock just says that the dead pwp no longer makes sense
on the local cpu and it can go now, without the local queuing work AFAICS
affected because of irq disabled. But it's hard to say how it will be
reclaimed on other cpus, say before this queuing ends, and this does
not matter in terms of the local queuing.
Hillf
next prev parent reply other threads:[~2019-12-12 2:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 10:46 [RFC 0/4] workqueue: fix selecting cpu for queuing work and cleanup Hillf Danton
2019-12-11 10:59 ` [RFC 1/4] workqueue: fix selecting cpu for queuing work Hillf Danton
2019-12-11 23:07 ` Daniel Jordan
2020-01-23 22:37 ` Daniel Jordan
2020-01-24 1:01 ` Hillf Danton
2019-12-11 11:12 ` [RFC 2/4] workqueue: use smp_processor_id() on " Hillf Danton
2019-12-11 11:22 ` [RFC 3/4] workqueue: reap dead pool workqueue " Hillf Danton
2019-12-11 23:25 ` Daniel Jordan
2019-12-12 2:28 ` Hillf Danton [this message]
2019-12-11 11:33 ` [RFC 4/4] workqueue: use integer for cpu " Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212022823.21144-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=daniel.m.jordan@oracle.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox