From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A26C43603 for ; Wed, 11 Dec 2019 23:25:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C952621556 for ; Wed, 11 Dec 2019 23:25:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="R8tBwyGh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C952621556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63B316B3477; Wed, 11 Dec 2019 18:25:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C3DD6B3478; Wed, 11 Dec 2019 18:25:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48BCF6B3479; Wed, 11 Dec 2019 18:25:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id 2EAD06B3477 for ; Wed, 11 Dec 2019 18:25:03 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id D466E180AD81C for ; Wed, 11 Dec 2019 23:25:02 +0000 (UTC) X-FDA: 76254443244.13.quill14_6634d7ac2430b X-HE-Tag: quill14_6634d7ac2430b X-Filterd-Recvd-Size: 3729 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 23:25:02 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBBMxSSK116104; Wed, 11 Dec 2019 23:24:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=B65H/agzDcjgNC5hqDt4i9zRG5ZTYsjrllkhNt7z4Nw=; b=R8tBwyGhmO2rEaYvX2LYP6AYc4XsuJErBUT652JfkN+lYcI4ORyC+RdluFwDPG3vCy8N u4SAVOBXoSEOkmJgDUpdC01hq0dLjoe7ygw3QoHS33CdBwT/0c0/h79ioOe8ZOj9MEE6 /rOotgpP8rYsuykjTOfeiqIK2EL/Poj+5TA+692Xbrg5JlU1k3hnX97iGYAAUxfv8UTH 9QQQKlaMFwLToMCjXxMVktslwJ1vq5tgLrIJtGFDqJI/XJdSnYl7qETV5z+63IHkk9b7 0Obt+GcNW4ZYEztzTrtI30kCpgubreb4llzEecyWh+cD7ngUoqhISvfU1NrPWbk9Av/Z jA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2wr4qrqpc3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Dec 2019 23:24:58 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBBMxEZ4078792; Wed, 11 Dec 2019 23:24:58 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2wu3k0298f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Dec 2019 23:24:58 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xBBNOuee008494; Wed, 11 Dec 2019 23:24:56 GMT Received: from ca-dmjordan1.us.oracle.com (/10.211.9.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 11 Dec 2019 15:24:56 -0800 Date: Wed, 11 Dec 2019 18:25:04 -0500 From: Daniel Jordan To: Hillf Danton Cc: linux-kernel , linux-mm , Tejun Heo , Lai Jiangshan Subject: Re: [RFC 3/4] workqueue: reap dead pool workqueue on queuing work Message-ID: <20191211232504.ih7ms7pwymzeaiym@ca-dmjordan1.us.oracle.com> References: <20191211104601.16468-1-hdanton@sina.com> <20191211112229.22652-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211112229.22652-1-hdanton@sina.com> User-Agent: NeoMutt/20180716 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=987 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912110181 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912110181 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000450, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 11, 2019 at 07:22:29PM +0800, Hillf Danton wrote: > Release rcu lock to reap dead pool workqueue. What's to be gained by reaping the pwq (and possibly worker pool and wq) before __queue_work() retries? It'll just happen after the queueing finishes.