From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A6EAC43603 for ; Wed, 11 Dec 2019 20:43:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D2DC5206A5 for ; Wed, 11 Dec 2019 20:43:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NcEGA0Ek" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2DC5206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 664EF6B33DC; Wed, 11 Dec 2019 15:43:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 615466B33DD; Wed, 11 Dec 2019 15:43:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 504296B33DE; Wed, 11 Dec 2019 15:43:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 39D456B33DC for ; Wed, 11 Dec 2019 15:43:55 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id F3ED1180AD81C for ; Wed, 11 Dec 2019 20:43:54 +0000 (UTC) X-FDA: 76254037188.12.crowd95_4f19ad874a35 X-HE-Tag: crowd95_4f19ad874a35 X-Filterd-Recvd-Size: 2810 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 20:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6vrmgfi+4nbdOkVEhxkfkbfonRvSVMuVgBeRSgTCURI=; b=NcEGA0EkSkv9urc5oY45erA5Z kXMIkX3ZMDeFK8SWl9RakM896GU6zgqje8VCLvgL5UJGrzzEr41Qo1pjfNiqQsyziQ2Dk9hJ+5lE+ QIgQkDtzXTe7pXcKDDRyhb07+79di9ZGqv/adl8bpbOrU+YrVDloSW8xdbTdhm9i4dG2m6IW83Ba6 ybYDR4rrxzAkdx6chLYkVLYLqCqdwW309zN3WiWY+N09/Nfa6s7vSYsVbU6bZc9YhRoUtYp/CC3AX eSgWkApm5FVsSIPQrdYEd61PvbDxXpHygQNjynxLQpBIBGpG4m/uvjY0LDDx5eAH9h1WgzKXKfQ3N xfRTG8YiA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1if8pp-0005Dn-Py; Wed, 11 Dec 2019 20:43:49 +0000 Date: Wed, 11 Dec 2019 12:43:49 -0800 From: Matthew Wilcox To: Jens Axboe Cc: Linus Torvalds , Linux-MM , linux-fsdevel , linux-block , Chris Mason , Dave Chinner , Johannes Weiner Subject: Re: [PATCHSET v3 0/5] Support for RWF_UNCACHED Message-ID: <20191211204349.GO32169@bombadil.infradead.org> References: <20191211152943.2933-1-axboe@kernel.dk> <0d4e3954-c467-30a7-5a8e-7c4180275533@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d4e3954-c467-30a7-5a8e-7c4180275533@kernel.dk> User-Agent: Mutt/1.12.1 (2019-06-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 11, 2019 at 01:08:32PM -0700, Jens Axboe wrote: > > The fact that you see that xas_create() so prominently would imply > > perhaps add_to_swap_cache(), which certainly implies that the page > > shrinking isn't hitting the file pages... > > That's presumably misleading, as it's just lookups. But yes, > confusing... While xas_create() could be called directly, it's more often called through xas_store() ... which would be called if we're storing a shadow entry to replace a page, which this workload would presumably be doing.