From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF22C2D0C6 for ; Wed, 11 Dec 2019 17:47:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 761602173E for ; Wed, 11 Dec 2019 17:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="COcgnXUB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 761602173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1454A6B3329; Wed, 11 Dec 2019 12:47:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F5B96B332A; Wed, 11 Dec 2019 12:47:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00B816B332B; Wed, 11 Dec 2019 12:47:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id DCA116B3329 for ; Wed, 11 Dec 2019 12:47:07 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 92F032465 for ; Wed, 11 Dec 2019 17:47:07 +0000 (UTC) X-FDA: 76253591694.03.owner91_3e2b856855004 X-HE-Tag: owner91_3e2b856855004 X-Filterd-Recvd-Size: 3449 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 17:47:06 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id t17so20152343ilm.13 for ; Wed, 11 Dec 2019 09:47:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=mv3G6o6Z9tMj7+Sy/jZZ8/jXLx9VysmevIPlbyPHn/8=; b=COcgnXUBNYB/Rl3Oki0yRZgpspChEw1cmbd5Q5u7Y9YzoVtN8IE2CvhR3GmlisPDH3 y+8cYeLLNU4MDl4rIKvcdMNsPMauYStsjkzXCY2lZ5Rh6UDz5SeYWrQb77PNA0C8qBcy pAjQBGvKqvE2MOoUGnMfAmIT9IrE0mqum4GGR4PZuTj97S/GrpAsxZ6X6vALkfn4XTkg GJKH/oNkOYrM1VsxEODQMsu74179Ino84p6bLrxMsLnCSwtM130435A821IWZnn6jh0i Owwq93pMCAXitfQcthPN9OO2rCw8XBZB7GL5vCza9x4XSmI+mNMXyft02kd3RO8iB7EN kWJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mv3G6o6Z9tMj7+Sy/jZZ8/jXLx9VysmevIPlbyPHn/8=; b=GMzw+A2h4kFDmvbgjLPgFq8SG9nfLJrJNIDp8iOIOFSL65dWpSoiKF5C4OTeHV5O/T d/H74tdOwvVz2nEjJeKzbrFY32rbAmG/QjeWwi49HlMGretNZ2hsNPT+m7Hzv6S9CkMO 78hnCRgk1Yyt0Y8HlJkpdJXnKuecnsHx5LCNDn3dGJVrBf9XB624FDjNuP/Puob+seTI 3blhrRSOKCYKkCrKWpeqggeGpFU4PbvKRQOx2sPxYjTPg7wvtUy5Xiw5g8625h+8s44G 3HNFCGObnouGJrkcTZFqfquulHtM8Wd/m/1GOJ8fOjs2GP9bFHcxo6peflsfRt9RYpKN wyig== X-Gm-Message-State: APjAAAVBzVZs7/4KMd9eXUHQdMkhx4ddhxjHKW4j1GFZLBDDp+N9dI+l T9D8VuHYC/xLSgCkiFwBjew= X-Google-Smtp-Source: APXvYqxTeHmeiR/F/c3T6cnthW2k8jzvG61BeBNihjMnIFLpN5suFslzeokdOLRH+9CG0LrXRsChtQ== X-Received: by 2002:a92:c0c7:: with SMTP id t7mr4442152ilf.113.1576086426189; Wed, 11 Dec 2019 09:47:06 -0800 (PST) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id o83sm902731ild.13.2019.12.11.09.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 09:47:05 -0800 (PST) From: Navid Emamdoost To: Andrew Morton , "Kirill A. Shutemov" , Keith Busch , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: emamd001@umn.edu, Navid Emamdoost Subject: [PATCH] mm/gup: Fix memory leak in __gup_benchmark_ioctl Date: Wed, 11 Dec 2019 11:46:51 -0600 Message-Id: <20191211174653.4102-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In the implementation of __gup_benchmark_ioctl() the allocated pages should be released before returning in case of an invalid cmd. Release pages via kvfree(). Fixes: 714a3a1ebafe ("mm/gup_benchmark.c: add additional pinning methods") Signed-off-by: Navid Emamdoost --- mm/gup_benchmark.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/gup_benchmark.c b/mm/gup_benchmark.c index 7dd602d7f8db..b160638f647e 100644 --- a/mm/gup_benchmark.c +++ b/mm/gup_benchmark.c @@ -63,6 +63,7 @@ static int __gup_benchmark_ioctl(unsigned int cmd, NULL); break; default: + kvfree(pages); return -1; } -- 2.17.1