From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: emamd001@umn.edu, Navid Emamdoost <navid.emamdoost@gmail.com>
Subject: [PATCH] mm/gup: Fix memory leak in __gup_benchmark_ioctl
Date: Wed, 11 Dec 2019 11:46:51 -0600 [thread overview]
Message-ID: <20191211174653.4102-1-navid.emamdoost@gmail.com> (raw)
In the implementation of __gup_benchmark_ioctl() the allocated pages
should be released before returning in case of an invalid cmd. Release
pages via kvfree().
Fixes: 714a3a1ebafe ("mm/gup_benchmark.c: add additional pinning methods")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
mm/gup_benchmark.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/gup_benchmark.c b/mm/gup_benchmark.c
index 7dd602d7f8db..b160638f647e 100644
--- a/mm/gup_benchmark.c
+++ b/mm/gup_benchmark.c
@@ -63,6 +63,7 @@ static int __gup_benchmark_ioctl(unsigned int cmd,
NULL);
break;
default:
+ kvfree(pages);
return -1;
}
--
2.17.1
next reply other threads:[~2019-12-11 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 17:46 Navid Emamdoost [this message]
2019-12-12 23:14 ` Ira Weiny
2019-12-13 21:40 ` John Hubbard
2019-12-13 22:23 ` Andrew Morton
2019-12-13 22:39 ` Navid Emamdoost
2019-12-13 22:37 ` [PATCH v2] " Navid Emamdoost
2019-12-13 23:12 ` Ira Weiny
2019-12-14 0:44 ` John Hubbard
2019-12-14 18:10 ` Markus Elfring
2019-12-16 12:18 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211174653.4102-1-navid.emamdoost@gmail.com \
--to=navid.emamdoost@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=emamd001@umn.edu \
--cc=keith.busch@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox