From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464BBC43603 for ; Wed, 11 Dec 2019 17:19:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0C65820409 for ; Wed, 11 Dec 2019 17:19:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KNiLzZ+z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C65820409 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9BDAA6B330E; Wed, 11 Dec 2019 12:19:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96EEA6B330F; Wed, 11 Dec 2019 12:19:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85DEC6B3310; Wed, 11 Dec 2019 12:19:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id 6BB036B330E for ; Wed, 11 Dec 2019 12:19:33 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 1683A180AD80F for ; Wed, 11 Dec 2019 17:19:33 +0000 (UTC) X-FDA: 76253522226.14.rock04_7074183738b36 X-HE-Tag: rock04_7074183738b36 X-Filterd-Recvd-Size: 2616 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 17:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4J1/yyuW0sNFMU7Tk1XR5eA0O0XmmxHDThV9Nk2vS4w=; b=KNiLzZ+zcRizZMcYKB+qUzvj9 upGmxAtf1ZzuI8xsrW9scHBlL5obgREKcLChcXDP7sYkF9zTA/B3Njsr310I0KOtUkAwo05H0A3qQ Jd0glkUxavowLKxezSEDPelvmfYEK8qcQ1C+z4VhfMNFc/wIopiTTW9S5xPDghr7PY9u/es4onZvZ kznr4CwqND97O2wGkTBqYyZTgiKjBjdKG/+YIqtoW5szoMeVgud61SuN5VKJwEh6UtRYfYYxtPjCM Xhptv0KTh0/dZp1/jUvmOqky5NRPTONHg3QTt/PdZRNQqmRReogjis47QtRZif3KikUHP8l8uvzRt L6SIxDRLg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1if5e4-0004tT-O2; Wed, 11 Dec 2019 17:19:28 +0000 Date: Wed, 11 Dec 2019 09:19:28 -0800 From: Matthew Wilcox To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, clm@fb.com, torvalds@linux-foundation.org, david@fromorbit.com Subject: Re: [PATCH 5/5] iomap: support RWF_UNCACHED for buffered writes Message-ID: <20191211171928.GN32169@bombadil.infradead.org> References: <20191211152943.2933-1-axboe@kernel.dk> <20191211152943.2933-6-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211152943.2933-6-axboe@kernel.dk> User-Agent: Mutt/1.12.1 (2019-06-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 11, 2019 at 08:29:43AM -0700, Jens Axboe wrote: > @@ -670,9 +675,14 @@ iomap_write_begin(struct inode *inode, loff_t pos, unsigned len, unsigned flags, > iomap_read_inline_data(inode, page, srcmap); > else if (iomap->flags & IOMAP_F_BUFFER_HEAD) > status = __block_write_begin_int(page, pos, len, NULL, srcmap); > - else > - status = __iomap_write_begin(inode, pos, len, flags, page, > + else { > + unsigned wb_flags = 0; > + > + if (flags & IOMAP_UNCACHED) > + wb_flags = IOMAP_WRITE_F_UNCACHED; > + status = __iomap_write_begin(inode, pos, len, wb_flags, page, > srcmap); I think if you do an uncached write to a currently shared extent, you just lost the IOMAP_WRITE_F_UNSHARE flag?