From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A9E1C43603 for ; Tue, 10 Dec 2019 22:19:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 49F5C2053B for ; Tue, 10 Dec 2019 22:19:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="iS3GKONz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49F5C2053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB1CD6B2E96; Tue, 10 Dec 2019 17:19:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D60D06B2E97; Tue, 10 Dec 2019 17:19:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28E86B2E98; Tue, 10 Dec 2019 17:19:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id ABCDA6B2E96 for ; Tue, 10 Dec 2019 17:19:39 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 52388180AD81F for ; Tue, 10 Dec 2019 22:19:39 +0000 (UTC) X-FDA: 76250649678.27.back53_3718cb922092b X-HE-Tag: back53_3718cb922092b X-Filterd-Recvd-Size: 4642 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Dec 2019 22:19:37 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBAME8aK137834; Tue, 10 Dec 2019 22:19:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=V7NOZM87Hjo3aH85Tq0UMYJwfwxR0GULXsdxgUGpUIg=; b=iS3GKONzKGMUa3EaM0O0NhvcAW/iG7hEk43Pi/ciGvg5J2j6uemEbhNIYdyZcCUV6Gnl IF1zKbNQ+cW9QoyaOp4Bj+Mh3gv87Zdzbi599PzAXTQ5sCuGtrCSm0CqsZkqAJY/dTF4 8T01Nh/C9dbkCkqZBAGZMagCMrkjM+TZ/XLAVw+odnDtoKOOLNdTNElSduSGasvTQTXy +lIHRrXiRwBTOM6/TG4DajAGjnKLetFKXe4JaygKnhbxSN+TQXvyiO030SMahQgViKsO 5GOLZcNtEQL5Fyt+uO+L1TIIc8B8GiNiRsksrHXf6bv+U5SoK2igY+vOMjpy3i2Hh7vT Mw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2wrw4n5y9p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 22:19:33 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBAMJ8g3075501; Tue, 10 Dec 2019 22:19:33 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2wte9asq7m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 22:19:29 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xBAMI5ZW018162; Tue, 10 Dec 2019 22:18:05 GMT Received: from ca-dmjordan1.us.oracle.com (/10.211.9.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 10 Dec 2019 14:18:04 -0800 Date: Tue, 10 Dec 2019 17:18:14 -0500 From: Daniel Jordan To: David Hildenbrand Cc: Daniel Jordan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Naoya Horiguchi , Pavel Tatashin , Andrew Morton , Steven Sistare , Michal Hocko , Bob Picco , Oscar Salvador Subject: Re: [PATCH v1 1/3] mm: fix uninitialized memmaps on a partially populated last section Message-ID: <20191210221814.bdgd4rw55paowhpv@ca-dmjordan1.us.oracle.com> References: <20191209174836.11063-1-david@redhat.com> <20191209174836.11063-2-david@redhat.com> <20191209211502.zhbvzv2qwbvcperm@ca-dmjordan1.us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9467 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912100183 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9467 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912100183 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000272, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 10, 2019 at 11:11:03AM +0100, David Hildenbrand wrote: > Some things that might be relevant from my config. > > # CONFIG_PAGE_POISONING is not set > CONFIG_DEFERRED_STRUCT_PAGE_INIT=y > CONFIG_SPARSEMEM_EXTREME=y > CONFIG_SPARSEMEM_VMEMMAP_ENABLE=y > CONFIG_SPARSEMEM_VMEMMAP=y > CONFIG_HAVE_MEMBLOCK_NODE_MAP=y > CONFIG_MEMORY_HOTPLUG=y > CONFIG_MEMORY_HOTPLUG_SPARSE=y > CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=y Thanks for all that. After some poking around, turns out enabling DEBUG_VM with its page poisoning let me hit it right away, which makes me wonder how often someone would see this without it. Anyway, fix looks good to me. Tested-by: Daniel Jordan