From: Chris Down <chris@chrisdown.name>
To: chengkaitao <pilgrimtao@gmail.com>
Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com,
akpm@linux-foundation.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
smuchun@gmail.com, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v2] mm: cleanup some useless code
Date: Tue, 10 Dec 2019 21:04:03 +0000 [thread overview]
Message-ID: <20191210210403.GA455280@chrisdown.name> (raw)
In-Reply-To: <20191210160450.3395-1-pilgrimtao@gmail.com>
chengkaitao writes:
>Subject: Re: [PATCH v2] mm: cleanup some useless code
Can you please write a more descriptive commit title? Seeing this in the commit
history tells the reader nothing, "code" could mean anything from a state
machine to a boolean, and "cleanup" could mean anything from some complex
refactoring to something trivial like this, and right now I have to look and
see the individual commit. This patch is really just deduplication of effort.
Perhaps:
mm, memcg: Don't check PageTransHuge before calling hpage_nr_pages
>It is much simpler to just use hpage_nr_pages for nr_pages and replace
>the local variable by PageTransHuge check directly
Heh, calling it "much" simpler seems a bit excessive. I mean, the code is just
as readable in both cases, but if it's going to go in, then that's fine. Any
merge conflict should be trivial enough to fix.
>Signed-off-by: Kaitao Cheng <pilgrimtao@gmail.com>
>Acked-by: Michal Hocko <mhocko@suse.com>
I'm indifferent to this patch, but after the title change:
Acked-by: Chris Down <chris@chrisdown.name>
prev parent reply other threads:[~2019-12-10 21:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 16:04 chengkaitao
2019-12-10 21:04 ` Chris Down [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210210403.GA455280@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=pilgrimtao@gmail.com \
--cc=smuchun@gmail.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox