From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89345C43603 for ; Tue, 10 Dec 2019 13:41:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4AC822073D for ; Tue, 10 Dec 2019 13:41:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jAqsM/qU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AC822073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D3A8C6B2C96; Tue, 10 Dec 2019 08:41:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC3836B2C97; Tue, 10 Dec 2019 08:41:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB2EF6B2C98; Tue, 10 Dec 2019 08:41:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id A2CB76B2C96 for ; Tue, 10 Dec 2019 08:41:42 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 55DCE824999B for ; Tue, 10 Dec 2019 13:41:42 +0000 (UTC) X-FDA: 76249344444.30.scene22_2be2013c72950 X-HE-Tag: scene22_2be2013c72950 X-Filterd-Recvd-Size: 3902 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Dec 2019 13:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ftX9rvm1yHZa4SUpNOQRgZGTA7du9HcjWYSa3Fi88Wo=; b=jAqsM/qUhmvw4P1Bolh5cygJ3 hsbrlYtszIVFAu/Uxu1V6Mj+pSAeMQtx72QJYGIrX/2dGESI0JBL14Wij2exyavRDLZNVsksN3Qxt bIt9sgdQlvH0PRlPFwCCqIFQY/QBgOYVpcCEAcLzEFHU7lm62M+Ztlz7ihaJBlweBioVHZ+aZLGCL PVJUwBX1ySkYfQB3iBmM0v8qqtPK4pH68epCCof/Nf4eDtD7UyK+wqHG5ESjWPmmDEW3JeICjR//W HWCQQ1osShwzmfRxfa0z2pi4zet4xq5yEJXubTH6Mad7F1c9b1jRoTy+rogQZ89lu3LQkdP+pnAT1 8Ae1f/y7Q==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iefld-00068N-HF; Tue, 10 Dec 2019 13:41:33 +0000 Date: Tue, 10 Dec 2019 05:41:33 -0800 From: Matthew Wilcox To: Alex Shi Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, shakeelb@google.com, hannes@cmpxchg.org, Michal Hocko , Vladimir Davydov , Roman Gushchin , Chris Down , Thomas Gleixner , Vlastimil Babka , Qian Cai , Andrey Ryabinin , "Kirill A. Shutemov" , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrea Arcangeli , David Rientjes , "Aneesh Kumar K.V" , swkhack , "Potyra, Stefan" , Mike Rapoport , Stephen Rothwell , Colin Ian King , Jason Gunthorpe , Mauro Carvalho Chehab , Peng Fan , Nikolay Borisov , Ira Weiny , Kirill Tkhai , Yafang Shao Subject: Re: [PATCH v5 2/8] mm/lru: replace pgdat lru_lock with lruvec lock Message-ID: <20191210134133.GI32169@bombadil.infradead.org> References: <1575978384-222381-1-git-send-email-alex.shi@linux.alibaba.com> <1575978384-222381-3-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1575978384-222381-3-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 10, 2019 at 07:46:18PM +0800, Alex Shi wrote: > -static void lock_page_lru(struct page *page, int *isolated) > +static struct lruvec *lock_page_lru(struct page *page, int *isolated) > { > - pg_data_t *pgdat = page_pgdat(page); > + struct lruvec *lruvec = lock_page_lruvec_irq(page); > > - spin_lock_irq(&pgdat->lru_lock); > if (PageLRU(page)) { > - struct lruvec *lruvec; > > - lruvec = mem_cgroup_page_lruvec(page, pgdat); > ClearPageLRU(page); > del_page_from_lru_list(page, lruvec, page_lru(page)); > *isolated = 1; > } else > *isolated = 0; > + > + return lruvec; > } I still don't understand how this is supposed to work for !PageLRU pages. Which lruvec have you locked if this page isn't on an LRU?