From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A7EFC43603 for ; Mon, 9 Dec 2019 20:43:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3BE182068E for ; Mon, 9 Dec 2019 20:43:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BE182068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B05196B2896; Mon, 9 Dec 2019 15:43:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB5B86B2897; Mon, 9 Dec 2019 15:43:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CBC66B2898; Mon, 9 Dec 2019 15:43:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 876206B2896 for ; Mon, 9 Dec 2019 15:43:50 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 3EC89180AD806 for ; Mon, 9 Dec 2019 20:43:50 +0000 (UTC) X-FDA: 76246779420.14.spy07_216e7ed5d1a45 X-HE-Tag: spy07_216e7ed5d1a45 X-Filterd-Recvd-Size: 2202 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Dec 2019 20:43:49 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 69ADB68BE1; Mon, 9 Dec 2019 21:43:45 +0100 (CET) Date: Mon, 9 Dec 2019 21:43:45 +0100 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Dan Williams , Andrew Morton , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra Subject: Re: [PATCH 0/6] Allow setting caching mode in arch_add_memory() for P2PDMA Message-ID: <20191209204345.GA29265@lst.de> References: <20191209191346.5197-1-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191209191346.5197-1-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 09, 2019 at 12:13:40PM -0700, Logan Gunthorpe wrote: > This changes is pretty routine for most of the arches: x86_64, s390, arm64 > and powerpc simply need to thread the pgprot through to where the page tables > are setup. x86_32 unfortunately sets up the page tables at boot so > must use _set_memory_prot() to change their caching mode. ia64 and sh > don't appear to have an easy way to change the page tables so, for now > at least, we just return -EINVAL on such mappings and thus they will > not support P2PDMA memory until the work for this is done. ia64 and sh don't support ZONE_DEVICE mappings anyway as far as I know. This generally looks fine to me.