From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35DD4C43603 for ; Sat, 7 Dec 2019 22:03:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AFCF1206DF for ; Sat, 7 Dec 2019 22:03:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IlO3aG3F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFCF1206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 249C96B1DA6; Sat, 7 Dec 2019 17:03:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F9F36B1DA7; Sat, 7 Dec 2019 17:03:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C2B36B1DA8; Sat, 7 Dec 2019 17:03:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id EA8EA6B1DA6 for ; Sat, 7 Dec 2019 17:03:27 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 940104DCA for ; Sat, 7 Dec 2019 22:03:27 +0000 (UTC) X-FDA: 76239722454.21.rice20_1e283ec303354 X-HE-Tag: rice20_1e283ec303354 X-Filterd-Recvd-Size: 4179 Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Sat, 7 Dec 2019 22:03:27 +0000 (UTC) Received: by mail-il1-f195.google.com with SMTP id r81so9447884ilk.0 for ; Sat, 07 Dec 2019 14:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5nppC0dn8qY+mD1E09P6PznSd/Bh4xxBWze2A2WO09Q=; b=IlO3aG3FRZD0xu9tViplgiGfRS37CuKkEj2ScqdH3KZ2Bzcf4tsYAuLrY+OW7xfQnQ Y4MC304D5enhqMluX9wGOBUfm37Pl9zvBr+WVyglzg9SPMpmkcYgp2SnFHdUYwLnO4cX DS7ikHBIbZzG3fH1dX50B8kyiQCeWdjPlBaZc032SH4U7bI5SbHRtXnuR3W2li8k287E 9BVwgTzbdRsqz6dzswTUZXsU4WAFUT+LTebfprvvvhUrJFfFfQsRE55FtVj8K0xhgEeP 9HGnDHVOEBAVzlqhNR8XCTnBLiIIAkwxbeJqD85vR86m07DIl75XL3s1my1wr54vmExX F6og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5nppC0dn8qY+mD1E09P6PznSd/Bh4xxBWze2A2WO09Q=; b=U8HsD4yDwPUoCc2MloFCIkNp5mmTvLEOLrocaArSbCkX85xeKwZkpgl1ohK+qxuHuS AqiKOODVcagfhLaIlQ+AlDKfaHfNuQxtiqi71MooPtrTaO+skVh+NnBop1N7Jkygn3Pq 2Ipx/xHzbPMmKUUzDycrTkcrDXMmDpc0wNRxH4ueKpC69ua5tBL0YzmlUOHUhlMIojXd eCvAkVdSbLTUGnrf8gb7jWXEIM/nZ9yQiveNuku09us16WFfrp2ionD4HAQvafz5xgS9 qQHsPA12uK1IFwjHYLpqNsk2UaCEqJTWWKxvfnpUWoM1qvU5kIO7i+bPpoqcQYwkDBqd ww5w== X-Gm-Message-State: APjAAAUQhhyxX9GU6T4Ms5gk1qA9hA+AcF7sCg1YWI1zxNUZRRhw6FQr kDysK4dvJcmxfAAvXrDcdpepAQ== X-Google-Smtp-Source: APXvYqzL+apasGgFI7oEJW3eyBLX0JaAv4j90jb1OtOqnumSkM2Y/9UGCPlGMll2foI6bqYKtJ2v1Q== X-Received: by 2002:a92:5805:: with SMTP id m5mr20220506ilb.59.1575756206331; Sat, 07 Dec 2019 14:03:26 -0800 (PST) Received: from google.com ([2620:15c:183:0:209:9736:c663:27c3]) by smtp.gmail.com with ESMTPSA id y11sm5243668ilp.46.2019.12.07.14.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Dec 2019 14:03:25 -0800 (PST) Date: Sat, 7 Dec 2019 15:03:20 -0700 From: Yu Zhao To: Christopher Lameter Cc: Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , "Kirill A . Shutemov" , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" Subject: Re: [FIX] slub: Remove kmalloc under list_lock from list_slab_objects() V2 Message-ID: <20191207220320.GA67512@google.com> References: <20191108193958.205102-1-yuzhao@google.com> <20191108193958.205102-2-yuzhao@google.com> <20191109230147.GA75074@google.com> <20191110184721.GA171640@google.com> <20191130150908.06b2646edfa7bdc12a943c25@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 02, 2019 at 03:12:20PM +0000, Christopher Lameter wrote: > On Sat, 30 Nov 2019, Andrew Morton wrote: > > > > Perform the allocation in free_partial() before the list_lock is taken. > > > > No response here? It looks a lot simpler than the originally proposed > > patch? > > Yup. I prefer this one but its my own patch so I cannot Ack this. Hi, there is a pending question from Tetsuo-san. I'd be happy to ack once it's address.