From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDB4BC43603 for ; Fri, 6 Dec 2019 07:48:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B10C024677 for ; Fri, 6 Dec 2019 07:48:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B10C024677 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4977D6B14B0; Fri, 6 Dec 2019 02:48:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 446DA6B14B1; Fri, 6 Dec 2019 02:48:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35DD76B14B2; Fri, 6 Dec 2019 02:48:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 1F55D6B14B0 for ; Fri, 6 Dec 2019 02:48:00 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id C830E8248041 for ; Fri, 6 Dec 2019 07:47:59 +0000 (UTC) X-FDA: 76233937878.08.hate01_45c428a44204a X-HE-Tag: hate01_45c428a44204a X-Filterd-Recvd-Size: 3928 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Dec 2019 07:47:59 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id c20so4905276wmb.0 for ; Thu, 05 Dec 2019 23:47:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qtb1WWUgl9wqPcOJD9MpTiHXbCPls9RWYFCWxX8gA38=; b=M+UYNpbNSio7DUK6SurlT8JFk+G0ji+IvbJTZpA22RWRdNcuoooMbWW7ZWlg0k91OZ GZUWbLwG7V0OnP8A5t+fS/nVz8UB830nkPzu9PDL6hcoyrHPCxWLSW2ZYcgPHDqHwrIZ ZTgNPIHvhvMzLEI0lXcTXbmVUozz5z45LMe+MmoqQeqsB9CQMpSZfu1yvoopdyWszGfM 3TEKZ0RuoZSfYz1Bs3rxH330aYFiUJVifk04p9wFLp2YwvTOpdjzaWY7kFmSU3FUKeUH fGVAiVewNmcgE+gGz4yj9/i8rkumvDEKl76YgYHC+bu+WF2gdzDk2L695wJUrZRcJ4t5 /UZg== X-Gm-Message-State: APjAAAVqITV/V8lIC8JduwTA3kxREWb8JisLkpwBcwG+t28qwU8BoDli G2dF5xct+r3mYmIoQbdSieU= X-Google-Smtp-Source: APXvYqzgdNukLlA3rCQmi7utZ2az51NLS1sN4LCMUjSaTNjqwhS+410uEl0P6YTtOQzNh9pp1JteSA== X-Received: by 2002:a1c:30b:: with SMTP id 11mr9307143wmd.171.1575618478227; Thu, 05 Dec 2019 23:47:58 -0800 (PST) Received: from localhost (ip-37-188-170-11.eurotel.cz. [37.188.170.11]) by smtp.gmail.com with ESMTPSA id u18sm15209133wrt.26.2019.12.05.23.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2019 23:47:57 -0800 (PST) Date: Fri, 6 Dec 2019 08:47:56 +0100 From: Michal Hocko To: Yang Shi Cc: mtk.manpages@gmail.com, cl@linux.com, jhubbard@nvidia.com, cai@lca.pw, akpm@linux-foundation.org, linux-man@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes Message-ID: <20191206074756.GI28317@dhcp22.suse.cz> References: <1575596090-115377-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1575596090-115377-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 06-12-19 09:34:50, Yang Shi wrote: > Since commit e78bbfa82624 ("mm: stop returning -ENOENT > from sys_move_pages() if nothing got migrated"), move_pages doesn't > return -ENOENT anymore if the pages are already on the target nodes, but > this change is never reflected in manpage. > > Cc: Michael Kerrisk > Cc: Christoph Lameter > Cc: John Hubbard > Cc: Michal Hocko > Cc: Qian Cai > Signed-off-by: Yang Shi > --- > man2/move_pages.2 | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/man2/move_pages.2 b/man2/move_pages.2 > index 2d96468..2a2f3cd 100644 > --- a/man2/move_pages.2 > +++ b/man2/move_pages.2 > @@ -192,9 +192,8 @@ was specified or an attempt was made to migrate pages of a kernel thread. > One of the target nodes is not online. > .TP > .B ENOENT > -No pages were found that require moving. > -All pages are either already > -on the target node, not present, had an invalid address or could not be > +No pages were found. > +All pages are either not present, had an invalid address or could not be > moved because they were mapped by multiple processes. I would rather not put any specifics here because those reasons might differ in future. I would simply go with "No pages were found that require or could be moved." -- Michal Hocko SUSE Labs