From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB99C2D0C0 for ; Fri, 6 Dec 2019 07:35:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 92E6724679 for ; Fri, 6 Dec 2019 07:35:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92E6724679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC94A6B14A2; Fri, 6 Dec 2019 02:35:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D51DD6B14A3; Fri, 6 Dec 2019 02:35:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C19656B14A4; Fri, 6 Dec 2019 02:35:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id A579A6B14A2 for ; Fri, 6 Dec 2019 02:35:19 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3B7C9180AD81A for ; Fri, 6 Dec 2019 07:35:19 +0000 (UTC) X-FDA: 76233905958.01.dime04_689bf2b69ef05 X-HE-Tag: dime04_689bf2b69ef05 X-Filterd-Recvd-Size: 3288 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Dec 2019 07:35:18 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id n9so6210883wmd.3 for ; Thu, 05 Dec 2019 23:35:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TyEnM0ErjIPbJfUas4Rc8uwAWuUH9XQEwJswELT2XBM=; b=MO51L7CY54lDQ26wibd0knvP0lIxzLozM1aT6lhOx7hLcAMf6Tu+SPVShPR/E/ncVR vvKkc7IDQQyKGweZWNhbLO96jK7qW55UEHKNXNDlPHp8ehwObpsYfF+AlkSYuhEzLBxh DbsEmixBHVFdjS+j9asQJ/6pHxdTL2Wqe0gyF6sTyZZpZijPogBAa+17CyGMTKfX4k6S 2VYErweRXwNDHNoptjxb+XI/U0wNcnreS6Gr6Kn6409GB7p+/bY06X2fxQ62xqFEczw+ CrJcj3ciTT2MYw10WO24g2oedqkL5JCNNMZXuUKC7WEj+aJ+EJJ5c/jBi2IYoggIcDuJ YqIA== X-Gm-Message-State: APjAAAVkObWKW1Z2zRHWA+31sh8g5fSsq8og/qscA+xLe1Y5Z9uViqf3 RxQPPzsWgumVC9nrvqc3c8g= X-Google-Smtp-Source: APXvYqxMqJTdvmC8VrePF92jfpjNcRNRLwDaMoMIKM7+yrkmKV6C3nq+6QCBgOmZOdQ9wtQlW3Sf5Q== X-Received: by 2002:a1c:7914:: with SMTP id l20mr8727185wme.38.1575617717668; Thu, 05 Dec 2019 23:35:17 -0800 (PST) Received: from localhost (ip-37-188-170-11.eurotel.cz. [37.188.170.11]) by smtp.gmail.com with ESMTPSA id e19sm2488431wme.6.2019.12.05.23.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2019 23:35:16 -0800 (PST) Date: Fri, 6 Dec 2019 08:35:15 +0100 From: Michal Hocko To: Christopher Lameter Cc: Yang Shi , fabecassis@nvidia.com, jhubbard@nvidia.com, vbabka@suse.cz, mgorman@techsingularity.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [v3 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node Message-ID: <20191206073515.GH28317@dhcp22.suse.cz> References: <1575572053-128363-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 05-12-19 19:45:49, Cristopher Lameter wrote: > On Fri, 6 Dec 2019, Yang Shi wrote: > > > Felix Abecassis reports move_pages() would return random status if the > > pages are already on the target node by the below test program: > > Looks ok. > > Acked-by: Christoph Lameter > > Nitpicks: > > > @@ -1553,7 +1555,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr, > > if (PageHuge(page)) { > > if (PageHead(page)) { > > isolate_huge_page(page, pagelist); > > - err = 0; > > + err = 1; > > Add a meaningful constant instead of 1? Well 1 has a good meaning here actually. We have -errno or the number of queued pages. -- Michal Hocko SUSE Labs