From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E6A3C43603 for ; Thu, 5 Dec 2019 00:50:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 179102077B for ; Thu, 5 Dec 2019 00:50:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EMY6t5UZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 179102077B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE3756B0D75; Wed, 4 Dec 2019 19:50:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B93D96B0D76; Wed, 4 Dec 2019 19:50:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5C7E6B0D77; Wed, 4 Dec 2019 19:50:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 91FCE6B0D75 for ; Wed, 4 Dec 2019 19:50:07 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 53C9F5825 for ; Thu, 5 Dec 2019 00:50:07 +0000 (UTC) X-FDA: 76229256054.24.beef59_1063f66e1742 X-HE-Tag: beef59_1063f66e1742 X-Filterd-Recvd-Size: 2553 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 00:50:06 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1AC4122464; Thu, 5 Dec 2019 00:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575507006; bh=ksQfA3Irw3nxIBZM1RrbGlxEZEaA8VbpRT1OQ5UxWS4=; h=Date:From:To:Subject:In-Reply-To:From; b=EMY6t5UZ94kRFprDo1uXUgiYQGQXq78ecfJgl6wtnDs7FEPX237mHXtbVAyIogtPF 12mSW84g3+z8g5bFXqNSa4SFdMZDmffxg9y3hg/jjYRrpmwTXOs034kX87DCc0h008 Req0T0grP7wxVuGWW+Ms0ZreB/PfuWJ/7E5c8vF8= Date: Wed, 04 Dec 2019 16:50:05 -0800 From: Andrew Morton To: adobriyan@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 08/86] fs/proc/internal.h: shuffle "struct pde_opener" Message-ID: <20191205005005.l3R36mF_u%akpm@linux-foundation.org> In-Reply-To: <20191204164858.fe4ed8886e34ad9f3b34ea00@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Alexey Dobriyan Subject: fs/proc/internal.h: shuffle "struct pde_opener" List iteration takes more code than anything else which means embedded list_head should be the first element of the structure. Space savings: add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-18 (-18) Function old new delta close_pdeo 228 227 -1 proc_reg_release 86 82 -4 proc_entry_rundown 143 139 -4 proc_reg_open 298 289 -9 Link: http://lkml.kernel.org/r/20191004234753.GB30246@avx2 Signed-off-by: Alexey Dobriyan Signed-off-by: Andrew Morton --- fs/proc/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/proc/internal.h~proc-shuffle-struct-pde_opener +++ a/fs/proc/internal.h @@ -197,8 +197,8 @@ extern ssize_t proc_simple_write(struct * inode.c */ struct pde_opener { - struct file *file; struct list_head lh; + struct file *file; bool closing; struct completion *c; } __randomize_layout; _