From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE20C43215 for ; Mon, 2 Dec 2019 08:03:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9BD3E2146E for ; Mon, 2 Dec 2019 08:03:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="p3WWMLeE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BD3E2146E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DF26B6B0003; Mon, 2 Dec 2019 03:03:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA2926B0006; Mon, 2 Dec 2019 03:03:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C90E66B0007; Mon, 2 Dec 2019 03:03:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id B02406B0003 for ; Mon, 2 Dec 2019 03:03:18 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 40D0C4417 for ; Mon, 2 Dec 2019 08:03:18 +0000 (UTC) X-FDA: 76219461276.12.fire42_7416257a47507 X-HE-Tag: fire42_7416257a47507 X-Filterd-Recvd-Size: 4927 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Dec 2019 08:03:17 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id m6so31518546ljc.1 for ; Mon, 02 Dec 2019 00:03:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pZzAMwk10JqTjDXwgTJurkovZOHqxsdyWD2t9EmKVOQ=; b=p3WWMLeEJ/fPe3vlpWukc3E52B41OYT04vWL+sVy/5hBJUFLKkTJvLTDGlIbGL6iIn fw00EwBteZvV5N4AB+pHHH2/5HnqeBFUA1yKNWSisRIJxD3K3R2FLaV59i0E0D3MIpK7 RHDqcqOGLQAlbuTSIs6njIEiw2lNtmg+kUVj0Poexk+sQgQudXhN1FolwrZ9VYzpl+1a cB0C6EJa+VI6wmCi8ZsXd/jN79cO7nHqw3Gev+O0Nco3V7QWR3V6TrPd1ciJIxloMrH5 8tzldXn/qE02e1lopdnIDGwpTKQeGUYAollVWB8MkmDgadtNiBkKFLc9m2cqnAEIryYv tJBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pZzAMwk10JqTjDXwgTJurkovZOHqxsdyWD2t9EmKVOQ=; b=o7zyjCGvWZrRnsBobINpNHlq4Ee+kYZk/vWNThy0L9ids/BFNz3y271R8+bchSJgnX NvObK3H+mq6BAvdn2qF3Vx+XyDcaWej4oY3kSGL9XQEg5o7LFe1W0ujRMHGjicirsp7V 2kIU99LP7mblov+d4afIb81/qmaQfYoMaIEJnlcsFjHFK65fFn5faHOS9RG4yEKJJc8V 7gnFrHGsRmdi5KDLrKjw5aHVNzEq404oAhf0BXp760uku5qHQGzFWfYCpr3cDiC7d0iT 0ybs+EsueCjAbOpTxs9kKjerSOA0ymr+KLXLqoauPeDv4I/2Zk1Do6rrZBiQteUqSoOi OM+Q== X-Gm-Message-State: APjAAAVEsdMD1jtDLqS7J2aELhwZIaSwlDDhYugAoPAfdOUBosivd1/v XM3GeAAuJUSCJTz41/TFM+AyBw== X-Google-Smtp-Source: APXvYqw2xS4YykGPdeRcFE4NZLnndPBghVdFAcfy3CqcTLlc0mTqj0TGZ4HMlNzmb41uz0qVkwLKnw== X-Received: by 2002:a2e:2283:: with SMTP id i125mr30215378lji.244.1575273795843; Mon, 02 Dec 2019 00:03:15 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id m9sm5099306lfj.57.2019.12.02.00.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2019 00:03:14 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 1B9B6100F4E; Mon, 2 Dec 2019 11:03:15 +0300 (+03) Date: Mon, 2 Dec 2019 11:03:15 +0300 From: "Kirill A. Shutemov" To: Wei Yang Cc: Wei Yang , akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/page_vma_mapped: use PMD_SIZE instead of calculating it Message-ID: <20191202080315.oqtm3q7cyfkl5rma@box.shutemov.name> References: <20191128010321.21730-1-richardw.yang@linux.intel.com> <20191128083255.ab5rwj7gvktwunik@box.shutemov.name> <20191128212226.sfrhfs5m3q7m6tly@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191128212226.sfrhfs5m3q7m6tly@master> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 28, 2019 at 09:22:26PM +0000, Wei Yang wrote: > On Thu, Nov 28, 2019 at 11:32:55AM +0300, Kirill A. Shutemov wrote: > >On Thu, Nov 28, 2019 at 09:03:20AM +0800, Wei Yang wrote: > >> At this point, we are sure page is PageTransHuge, which means > >> hpage_nr_pages is HPAGE_PMD_NR. > >> > >> This is safe to use PMD_SIZE instead of calculating it. > >> > >> Signed-off-by: Wei Yang > >> --- > >> mm/page_vma_mapped.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c > >> index eff4b4520c8d..76e03650a3ab 100644 > >> --- a/mm/page_vma_mapped.c > >> +++ b/mm/page_vma_mapped.c > >> @@ -223,7 +223,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) > >> if (pvmw->address >= pvmw->vma->vm_end || > >> pvmw->address >= > >> __vma_address(pvmw->page, pvmw->vma) + > >> - hpage_nr_pages(pvmw->page) * PAGE_SIZE) > >> + PMD_SIZE) > >> return not_found(pvmw); > >> /* Did we cross page table boundary? */ > >> if (pvmw->address % PMD_SIZE == 0) { > > > >It is dubious cleanup. Maybe page_size(pvmw->page) instead? It will not > >break if we ever get PUD THP pages. > > > > Thanks for your comment. > > I took a look into the code again and found I may miss something. > > I found we support PUD THP pages, whilc hpage_nr_pages() just return > HPAGE_PMD_NR on PageTransHuge. Why this is not possible to return PUD number? We only support PUD THP for DAX. Means, we don't have struct page for it. -- Kirill A. Shutemov