From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8BE8C432C0 for ; Mon, 2 Dec 2019 07:22:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C236B20715 for ; Mon, 2 Dec 2019 07:22:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C236B20715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4C2786B0007; Mon, 2 Dec 2019 02:22:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 472E06B0008; Mon, 2 Dec 2019 02:22:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 388666B000A; Mon, 2 Dec 2019 02:22:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 1F7156B0007 for ; Mon, 2 Dec 2019 02:22:22 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id AB975181AEF1E for ; Mon, 2 Dec 2019 07:22:21 +0000 (UTC) X-FDA: 76219358082.21.pail20_31a7e67ded840 X-HE-Tag: pail20_31a7e67ded840 X-Filterd-Recvd-Size: 1457 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Dec 2019 07:22:21 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 6F6D268B05; Mon, 2 Dec 2019 08:22:18 +0100 (CET) Date: Mon, 2 Dec 2019 08:22:18 +0100 From: Christoph Hellwig To: lijiazi Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Andrew Morton , lijiazi , iommu@lists.linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] dma-mapping: do not mapping module memory Message-ID: <20191202072218.GB29554@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 29, 2019 at 07:03:40PM +0800, lijiazi wrote: > On ARM, x86_64, sparc64 platform, virt_to_page only convert a > _valid_ virtual address to struct page *, virt_addr_valid(x) > indicates whether a virtual address is valid. If ptr is point > to a static variable in module area, virt_to_page will return > a invalid value. While the path isn't wrong, why bother?