From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C17DC432C3 for ; Sun, 1 Dec 2019 01:49:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F2E72086A for ; Sun, 1 Dec 2019 01:49:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YXmdfDsi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F2E72086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D4EF46B0274; Sat, 30 Nov 2019 20:49:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D27A56B0275; Sat, 30 Nov 2019 20:49:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C14A16B0276; Sat, 30 Nov 2019 20:49:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id A42D76B0274 for ; Sat, 30 Nov 2019 20:49:49 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 59E7C824999B for ; Sun, 1 Dec 2019 01:49:49 +0000 (UTC) X-FDA: 76214891298.03.tooth75_8febd47e18e13 X-HE-Tag: tooth75_8febd47e18e13 X-Filterd-Recvd-Size: 3082 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Dec 2019 01:49:48 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EABA52084E; Sun, 1 Dec 2019 01:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575164988; bh=UAwlasgGfNqnfPY8d1A7JPTm2QF2si8jlDhqOnXo9mI=; h=Date:From:To:Subject:From; b=YXmdfDsi1tIgxzl+u9O7uh3ROoXYMn2egEfokDfZgnBtykw7XPz9yzDB6TmwY1Nmb mHdcId9ziXPyGmhXvrZO60GWR5HO9LIaS+X1n6Np494L7F1ZOiPiBGgSbVIH6BQ778 nW9TKGZ5tEEjGQmTLsFV7hD/1Euljl/j5NMKzS/o= Date: Sat, 30 Nov 2019 17:49:47 -0800 From: akpm@linux-foundation.org To: akpm@linux-foundation.org, axboe@kernel.dk, jack@suse.cz, khlebnikov@yandex-team.ru, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk Subject: [patch 013/158] mm/filemap.c: warn if stale pagecache is left after direct write Message-ID: <20191201014947.ru2upF2br%akpm@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Konstantin Khlebnikov Subject: mm/filemap.c: warn if stale pagecache is left after direct write generic_file_direct_write() tries to invalidate pagecache after O_DIRECT write. Unlike to similar code in dio_complete() this silently ignores error returned from invalidate_inode_pages2_range(). According to comment this code here because not all filesystems call dio_complete() to do proper invalidation after O_DIRECT write. Noticeable example is a blkdev_direct_IO(). This patch calls dio_warn_stale_pagecache() if invalidation fails. Link: http://lkml.kernel.org/r/157270038294.4812.2238891109785106069.stgit@buzz Signed-off-by: Konstantin Khlebnikov Reviewed-by: Andrew Morton Reviewed-by: Jan Kara Cc: Jens Axboe Cc: Alexander Viro Signed-off-by: Andrew Morton --- mm/filemap.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) --- a/mm/filemap.c~fs-warn-if-stale-pagecache-is-left-after-direct-write +++ a/mm/filemap.c @@ -3241,11 +3241,13 @@ generic_file_direct_write(struct kiocb * * do not end up with dio_complete() being called, so let's not break * them by removing it completely. * + * Noticeable example is a blkdev_direct_IO(). + * * Skip invalidation for async writes or if mapping has no pages. */ - if (written > 0 && mapping->nrpages) - invalidate_inode_pages2_range(mapping, - pos >> PAGE_SHIFT, end); + if (written > 0 && mapping->nrpages && + invalidate_inode_pages2_range(mapping, pos >> PAGE_SHIFT, end)) + dio_warn_stale_pagecache(file); if (written > 0) { pos += written; _