From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D03CAC432C0 for ; Sat, 30 Nov 2019 13:45:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D9A82075A for ; Sat, 30 Nov 2019 13:45:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LBo+ojo5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D9A82075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B4EFC6B05D8; Sat, 30 Nov 2019 08:45:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AFF916B05DB; Sat, 30 Nov 2019 08:45:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EF3C6B05DD; Sat, 30 Nov 2019 08:45:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 84FCC6B05D8 for ; Sat, 30 Nov 2019 08:45:07 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 2242F181AEF1E for ; Sat, 30 Nov 2019 13:45:07 +0000 (UTC) X-FDA: 76213065054.21.mint99_49b48e5e97b2e X-HE-Tag: mint99_49b48e5e97b2e X-Filterd-Recvd-Size: 6560 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Sat, 30 Nov 2019 13:45:06 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id m30so22710316lfp.8 for ; Sat, 30 Nov 2019 05:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EX4Yje1/DqSKTDoH2ZOXvXZz8HHNkGdgnUsG/hOKdBw=; b=LBo+ojo5F0qFie+DSdwph9KLg/o3L7MwcHZlKwFmgJev7vHe1yPc5GNfJAfvPYzRFP /QwdYwpfx+aiYOh970+jo4hXH2lYVMpel3gU+DHFjlotq9HIbNZizAULaBsQys6G8dws gZv5FoeQvDtlY4P5wN1yN5Q2F/Bn/qYwdi/zpx2TPfICYcsbdVucTdTzGHdBTl1a+aC7 VBz7/TnxIM/hbxRtxB1O1fJpLRga1/qi8gwAyRsaVt9J0XgO02dO4JDZk/tFzAfvkkmG liZYdkxJMt+F9fIEEuKpnqnMJr1yOu/QQVUzpsMj1oiib/nTNG9lvCI67L3xGM1WqgwT REKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EX4Yje1/DqSKTDoH2ZOXvXZz8HHNkGdgnUsG/hOKdBw=; b=dVWi27fF+QCAzc+v6DgJGhE7/62RtczbMoUX25ycqioQ/4iBrKK4ODS0ODkdkTn3w/ n1brazpWVm6bmMi2hro9R0JlHOIIUjtJIwvvBRHGhmTkbYjSwWzb3DWYdLf3LzUWK1Xm 0YXlz9PrPOPuJXIxqPC5klmUPkoxatNJLTGAIaO4ObI+cjpfZvB95rJ3ag+eaSzTyG6H 4iUxlBFScclC/pWrfw/g51US0l+ArI2m4ANQj6uNyVFHXdHPue/Ds27DaHA6JaiOf71+ +Cg7MYeS/up6rGJkg7wCeYeeW8mtra+CLkr8bYtEOy/7i29ftDDG40RvRCrrbTQpOoG0 x7cA== X-Gm-Message-State: APjAAAXS87LvaNVN7AUWTZMKAmZlTTpWCMXVu2XIO4nfaoNQMB8Z4tvy ic++Ne0da4MIDJwkqEZ1wP0= X-Google-Smtp-Source: APXvYqwffFXBV9levaCaoyAjZ6N3Xlb4xld38P9iySjZzBogdDca34FfBCP1vIsuhp7sEPVvV8yrzw== X-Received: by 2002:ac2:5c4a:: with SMTP id s10mr11141071lfp.88.1575121504733; Sat, 30 Nov 2019 05:45:04 -0800 (PST) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id a18sm11758745ljp.33.2019.11.30.05.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Nov 2019 05:45:03 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sat, 30 Nov 2019 14:44:55 +0100 To: Tetsuo Handa Cc: Dmitry Vyukov , syzbot , Daniel Axtens , kasan-dev , Andrew Morton , LKML , Linux-MM , syzkaller-bugs Subject: Re: BUG: sleeping function called from invalid context in __alloc_pages_nodemask Message-ID: <20191130134455.GA27399@pc636> References: <000000000000c280ba05988b6242@google.com> <77abfacd-cfd0-5a8d-4af7-e5847fb4e03a@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77abfacd-cfd0-5a8d-4af7-e5847fb4e03a@I-love.SAKURA.ne.jp> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 30, 2019 at 09:48:34PM +0900, Tetsuo Handa wrote: > On 2019/11/30 16:57, Dmitry Vyukov wrote: > > On Sat, Nov 30, 2019 at 8:35 AM syzbot > > wrote: > >> > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit: 419593da Add linux-next specific files for 20191129 > >> git tree: linux-next > >> console output: https://syzkaller.appspot.com/x/log.txt?x=12cc369ce00000 > >> kernel config: https://syzkaller.appspot.com/x/.config?x=7c04b0959e75c206 > >> dashboard link: https://syzkaller.appspot.com/bug?extid=4925d60532bf4c399608 > >> compiler: gcc (GCC) 9.0.0 20181231 (experimental) > >> > >> Unfortunately, I don't have any reproducer for this crash yet. > >> > >> IMPORTANT: if you fix the bug, please add the following tag to the commit: > >> Reported-by: syzbot+4925d60532bf4c399608@syzkaller.appspotmail.com > > > > +Daniel, kasan-dev > > This is presumably from the new CONFIG_KASAN_VMALLOC > > Well, this is because > > commit d005e4cdb2307f63b5ce5cb359964c5a72d95790 > Author: Uladzislau Rezki (Sony) > Date: Tue Nov 19 11:45:23 2019 +1100 > > mm/vmalloc: rework vmap_area_lock > > @@ -3363,29 +3369,38 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > va = vas[area]; > va->va_start = start; > va->va_end = start + size; > - > - insert_vmap_area(va, &vmap_area_root, &vmap_area_list); > } > > - spin_unlock(&vmap_area_lock); > + spin_unlock(&free_vmap_area_lock); > > /* insert all vm's */ > - for (area = 0; area < nr_vms; area++) > - setup_vmalloc_vm(vms[area], vas[area], VM_ALLOC, > + spin_lock(&vmap_area_lock); > + for (area = 0; area < nr_vms; area++) { > + insert_vmap_area(vas[area], &vmap_area_root, &vmap_area_list); > + > + setup_vmalloc_vm_locked(vms[area], vas[area], VM_ALLOC, > pcpu_get_vm_areas); > + } > + spin_unlock(&vmap_area_lock); > > kfree(vas); > return vms; > > made the iteration atomic context while > > commit 1800fa0a084c60a600be0cc43fc657ba5609fdda > Author: Daniel Axtens > Date: Tue Nov 19 11:45:23 2019 +1100 > > kasan: support backing vmalloc space with real shadow memory > > @@ -3380,6 +3414,9 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > > setup_vmalloc_vm_locked(vms[area], vas[area], VM_ALLOC, > pcpu_get_vm_areas); > + > + /* assume success here */ > + kasan_populate_vmalloc(sizes[area], vms[area]); > } > spin_unlock(&vmap_area_lock); > > tried to do sleeping allocation inside the iteration. There was a patch that fixes an attempt of "sleeping allocation" under the spinlock from Daniel: https://lkml.org/lkml/2019/11/20/22 -- Vlad Rezki