From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 238B0C432C0 for ; Thu, 28 Nov 2019 15:46:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFD2D2178F for ; Thu, 28 Nov 2019 15:46:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFD2D2178F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4BD346B054D; Thu, 28 Nov 2019 10:46:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 46DC36B054E; Thu, 28 Nov 2019 10:46:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 384146B054F; Thu, 28 Nov 2019 10:46:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 2021B6B054D for ; Thu, 28 Nov 2019 10:46:41 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id D92004DC1 for ; Thu, 28 Nov 2019 15:46:40 +0000 (UTC) X-FDA: 76206113760.05.knot27_12bdfe6b400 X-HE-Tag: knot27_12bdfe6b400 X-Filterd-Recvd-Size: 3079 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Nov 2019 15:46:40 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id z3so31669932wru.3 for ; Thu, 28 Nov 2019 07:46:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=sIubRS4qLZI1jaaKqOxxNv4bjCiQZULaHKOwIakIJiY=; b=GS5TMn5eWjOLDPMfl5zje7v4qsugT3rkROJQZZIk8UbOR4CR5y1uhlZGRm/+bSGhot w8/IsjUbO3sLYR8zel/lEEa+GKrd3lMvI03a7ma4zhwTlsefORBeFKEWTkmGiPAguBXI hmhWzbronWCACs0zY0vTYiLKwaT96CcJMiepVSc1uM1CaO/k0Ti7M+lEiVEezQ814TF4 qYw9mofl4tAMqizG0ibYweyai8PRAPAiQpQxYmrzlt/ZL1id3nx52EVIWxEPBlYJt+WA 1yfGP8aYJzNcpgojXbZaQFoItuRwGD5WSjRvuDGCie63rgxXdg2otHnVGb4Z6F4v8+c8 hLaA== X-Gm-Message-State: APjAAAXloMqqHnUqCjgYc7ttgoB7hIKXG+USSI2nfE4j69/TS6Sczu9L umaamqv7itk43QnhEoXqjJc= X-Google-Smtp-Source: APXvYqweU1Xq3ZlSnJcthj6s1cWlgUvpvTMSYvKjK+EzZFsvPtfmfrPAjkquxBMUXFmf8EH8boUJ5g== X-Received: by 2002:a5d:5222:: with SMTP id i2mr49099419wra.305.1574955999271; Thu, 28 Nov 2019 07:46:39 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id m9sm22790884wro.66.2019.11.28.07.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 07:46:38 -0800 (PST) Date: Thu, 28 Nov 2019 16:46:37 +0100 From: Michal Hocko To: Qian Cai Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Oscar Salvador Subject: Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn Message-ID: <20191128154637.GO26807@dhcp22.suse.cz> References: <687DAE43-C40F-4527-876D-CAC750D150B6@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <687DAE43-C40F-4527-876D-CAC750D150B6@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.313658, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 28-11-19 10:29:24, Qian Cai wrote: > What I don=E2=80=99t understand is that we have an policy prohibiting c= ode > churn like code optimization in cold path, but allow those micro > cleanup of code. Those cleanup also tend to be unregulated and is > subject to personal tastes (for example, your CS teachers may have a > different taste from mine). I tend to push back on cleanups without a clear added value. In this particular case it is not about aesthetic or a personal feeling about the code though. Please read my comment with the ack. --=20 Michal Hocko SUSE Labs