From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 138D6C43215 for ; Thu, 28 Nov 2019 08:33:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CAD682176D for ; Thu, 28 Nov 2019 08:33:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="fatrkrOJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAD682176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B5BD26B050B; Thu, 28 Nov 2019 03:32:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0B226B050C; Thu, 28 Nov 2019 03:32:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A48D86B050D; Thu, 28 Nov 2019 03:32:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 8DB036B050B for ; Thu, 28 Nov 2019 03:32:59 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 42F163A91 for ; Thu, 28 Nov 2019 08:32:59 +0000 (UTC) X-FDA: 76205020878.02.coil81_8e7090c78c025 X-HE-Tag: coil81_8e7090c78c025 X-Filterd-Recvd-Size: 4251 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Nov 2019 08:32:58 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id l14so19359228lfh.10 for ; Thu, 28 Nov 2019 00:32:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lIy277yxYKVobrZz2ToLDywtPrlz1UVDNYgv3IeN1Jg=; b=fatrkrOJr4qwMGagesnkLFa7gXLISGxz3MWjlGva/SQ19IbhGVVerqggDnbRpsqLE2 jVKi54KOnDC0o5PpvG5ebVRMGL8Ts94ShZAr7LpJbt2Du5ymMQuw5YDrSLcNGTyqqBIf WwcBWKFTcw8PdqDLjYLsPTBUx8BTQYUp+m6QcdtPGpLMXxj4ZvcZlxkhcgDnT4Q1tfrA MRLLO0273PUhmDabzseylDafZeeQssgZPMD/4JGNae91/ZgBoLS8nA6JqeHmPyA7THZK Cp2NL+mvNfxsIjM88h3T3JQOmSDz4Xv4/nMcyK8tcySjb+uAnn8+3DSzGX49LrAEs6Rk ol4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lIy277yxYKVobrZz2ToLDywtPrlz1UVDNYgv3IeN1Jg=; b=bqLBl+3VL3ruyjM0qXdaB3nasGv378vayF3E6R+nGLE3HnAtWlneVb4fA0DC98ajeh VZ2zK/DJKMaqGkTKLUPX1uzQ2tdHpG4B3SEDhzFj9aQH1ey+XDELefu9Kak0k86OiaJv 7rEh1XikP4KoiVw6WIucyDvlOOmLTwsz4TKjjDYOP/CRdliK51quC6Gkh7oVcNloZWsF WAPAbGcs9KVw3UF/At+XyF299WGr//MZjnLuTprG8UPFMlfoH1yN59Riiaim+00ye5Kc SRJvrQAELlt7D3tXmIpJileIEdaSiCfPeR5bP5ZYKm7yBUVHozRC6utb50UuFH03uf3Q QrfA== X-Gm-Message-State: APjAAAWMfRYmZp6LQU1jaJsIxtM4oNZ52wGLucvvCl2uDVIDX5N64UW0 sGsVV9W/UlHnqQk5qzM8p0bpGTvWKa4= X-Google-Smtp-Source: APXvYqxyczGbS/7hvESPwKMKR0/0KbuTnLjq1DmHGcjCr0kUQd2LoN2KVxqmC3Lm2OWL61xWHAtf7g== X-Received: by 2002:a19:4bd4:: with SMTP id y203mr29282721lfa.61.1574929977126; Thu, 28 Nov 2019 00:32:57 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id r4sm8192396ljn.64.2019.11.28.00.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2019 00:32:56 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id A6E76101715; Thu, 28 Nov 2019 11:32:55 +0300 (+03) Date: Thu, 28 Nov 2019 11:32:55 +0300 From: "Kirill A. Shutemov" To: Wei Yang Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/page_vma_mapped: use PMD_SIZE instead of calculating it Message-ID: <20191128083255.ab5rwj7gvktwunik@box.shutemov.name> References: <20191128010321.21730-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191128010321.21730-1-richardw.yang@linux.intel.com> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 28, 2019 at 09:03:20AM +0800, Wei Yang wrote: > At this point, we are sure page is PageTransHuge, which means > hpage_nr_pages is HPAGE_PMD_NR. > > This is safe to use PMD_SIZE instead of calculating it. > > Signed-off-by: Wei Yang > --- > mm/page_vma_mapped.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c > index eff4b4520c8d..76e03650a3ab 100644 > --- a/mm/page_vma_mapped.c > +++ b/mm/page_vma_mapped.c > @@ -223,7 +223,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) > if (pvmw->address >= pvmw->vma->vm_end || > pvmw->address >= > __vma_address(pvmw->page, pvmw->vma) + > - hpage_nr_pages(pvmw->page) * PAGE_SIZE) > + PMD_SIZE) > return not_found(pvmw); > /* Did we cross page table boundary? */ > if (pvmw->address % PMD_SIZE == 0) { It is dubious cleanup. Maybe page_size(pvmw->page) instead? It will not break if we ever get PUD THP pages. -- Kirill A. Shutemov