From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org
Cc: kirill.shutemov@linux.intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Wei Yang <richardw.yang@linux.intel.com>
Subject: [PATCH 1/2] mm/page_vma_mapped: use PMD_SIZE instead of calculating it
Date: Thu, 28 Nov 2019 09:03:20 +0800 [thread overview]
Message-ID: <20191128010321.21730-1-richardw.yang@linux.intel.com> (raw)
At this point, we are sure page is PageTransHuge, which means
hpage_nr_pages is HPAGE_PMD_NR.
This is safe to use PMD_SIZE instead of calculating it.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
mm/page_vma_mapped.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c
index eff4b4520c8d..76e03650a3ab 100644
--- a/mm/page_vma_mapped.c
+++ b/mm/page_vma_mapped.c
@@ -223,7 +223,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
if (pvmw->address >= pvmw->vma->vm_end ||
pvmw->address >=
__vma_address(pvmw->page, pvmw->vma) +
- hpage_nr_pages(pvmw->page) * PAGE_SIZE)
+ PMD_SIZE)
return not_found(pvmw);
/* Did we cross page table boundary? */
if (pvmw->address % PMD_SIZE == 0) {
--
2.17.1
next reply other threads:[~2019-11-28 1:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 1:03 Wei Yang [this message]
2019-11-28 1:03 ` [PATCH 2/2] mm/page_vma_mapped: page table boundary is already guaranteed Wei Yang
2019-11-28 8:31 ` Kirill A. Shutemov
2019-11-28 21:09 ` Wei Yang
2019-11-28 22:39 ` Matthew Wilcox
2019-11-29 8:30 ` Wei Yang
2019-11-29 11:18 ` Matthew Wilcox
2019-12-02 6:53 ` Wei Yang
2019-11-28 8:32 ` [PATCH 1/2] mm/page_vma_mapped: use PMD_SIZE instead of calculating it Kirill A. Shutemov
2019-11-28 21:22 ` Wei Yang
2019-12-02 8:03 ` Kirill A. Shutemov
2019-12-02 8:54 ` Wei Yang
2019-12-02 22:21 ` Wei Yang
2019-12-03 9:47 ` Kirill A. Shutemov
2019-12-03 15:14 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128010321.21730-1-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox